Skip to content

feat: refactor parent-child task coordination to event-driven architecture #6958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: refactor parent-child task coordination to event-driven architecture #6958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7507059
feat: refactor parent-child task coordination to use persistent state
roomote Aug 11, 2025
48df752
fix: update references to removed stack methods and add compatibility…
roomote Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/types/src/history.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ export const historyItemSchema = z.object({
size: z.number().optional(),
workspace: z.string().optional(),
mode: z.string().optional(),
// Parent-child task relationship fields
parentTaskId: z.string().optional(),
childTaskIds: z.array(z.string()).optional(),
taskStatus: z.enum(["active", "paused", "completed"]).optional(),
})

export type HistoryItem = z.infer<typeof historyItemSchema>
2 changes: 1 addition & 1 deletion src/activate/registerCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const getCommandsMap = ({ context, outputChannel, provider }: RegisterCommandOpt

TelemetryService.instance.captureTitleButtonClicked("plus")

await visibleProvider.removeClineFromStack()
await visibleProvider.deactivateCurrentTask()
await visibleProvider.postStateToWebview()
await visibleProvider.postMessageToWebview({ type: "action", action: "chatButtonClicked" })
// Send focusInput action immediately after chatButtonClicked
Expand Down
9 changes: 9 additions & 0 deletions src/core/task-persistence/taskMetadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ export type TaskMetadataOptions = {
globalStoragePath: string
workspace: string
mode?: string
parentTaskId?: string
childTaskIds?: string[]
taskStatus?: "active" | "paused" | "completed"
}

export async function taskMetadata({
Expand All @@ -28,6 +31,9 @@ export async function taskMetadata({
globalStoragePath,
workspace,
mode,
parentTaskId,
childTaskIds,
taskStatus,
}: TaskMetadataOptions) {
const taskDir = await getTaskDirectoryPath(globalStoragePath, taskId)

Expand Down Expand Up @@ -95,6 +101,9 @@ export async function taskMetadata({
size: taskDirSize,
workspace,
mode,
parentTaskId,
childTaskIds,
taskStatus,
}

return { historyItem, tokenUsage }
Expand Down
61 changes: 20 additions & 41 deletions src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
readonly parentTask: Task | undefined = undefined
readonly taskNumber: number
readonly workspacePath: string
childTaskIds: string[] = []
taskStatus: "active" | "paused" | "completed" = "active"

/**
* The mode associated with this task. Persisted across sessions
Expand Down Expand Up @@ -184,7 +186,6 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
isInitialized = false
isPaused: boolean = false
pausedModeSlug: string = defaultModeSlug
private pauseInterval: NodeJS.Timeout | undefined

// API
readonly apiConfiguration: ProviderSettings
Expand Down Expand Up @@ -574,7 +575,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
}
}

private async saveClineMessages() {
public async saveClineMessages() {
try {
await saveTaskMessages({
messages: this.clineMessages,
Expand All @@ -589,6 +590,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
globalStoragePath: this.globalStoragePath,
workspace: this.cwd,
mode: this._taskMode || defaultModeSlug, // Use the task's own mode, not the current provider mode
parentTaskId: this.parentTask?.taskId,
childTaskIds: this.childTaskIds,
taskStatus: this.taskStatus,
})

this.emit(RooCodeEventName.TaskTokenUsageUpdated, this.taskId, tokenUsage)
Expand Down Expand Up @@ -1002,6 +1006,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
public async resumePausedTask(lastMessage: string) {
// Release this Cline instance from paused state.
this.isPaused = false
this.taskStatus = "active"
Copy link
Contributor Author

@roomote roomote bot Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Race condition: taskStatus is set to "active" but saveClineMessages() is called without awaiting. If the system crashes between these operations, the status change is lost. Consider awaiting the save operation.

this.emit(RooCodeEventName.TaskUnpaused)

// Fake an answer from the subtask that it has completed running and
Expand All @@ -1014,6 +1019,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
role: "user",
content: [{ type: "text", text: `[new_task completed] Result: ${lastMessage}` }],
})

// Update task status in persistent storage
await this.saveClineMessages()
} catch (error) {
this.providerRef
.deref()
Expand Down Expand Up @@ -1263,12 +1271,6 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
public dispose(): void {
console.log(`[Task] disposing task ${this.taskId}.${this.instanceId}`)

// Stop waiting for child task completion.
if (this.pauseInterval) {
clearInterval(this.pauseInterval)
this.pauseInterval = undefined
}

// Release any terminals associated with this task.
try {
// Release any terminals associated with this task.
Expand Down Expand Up @@ -1341,21 +1343,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
}
}

// Used when a sub-task is launched and the parent task is waiting for it to
// finish.
// TBD: The 1s should be added to the settings, also should add a timeout to
// prevent infinite waiting.
public async waitForResume() {
await new Promise<void>((resolve) => {
this.pauseInterval = setInterval(() => {
if (!this.isPaused) {
clearInterval(this.pauseInterval)
this.pauseInterval = undefined
resolve()
}
}, 1000)
})
}
// Direct resumption - no polling needed
// The child task will directly call resumePausedTask() on the parent

// Task Loop

Expand Down Expand Up @@ -1425,27 +1414,17 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.consecutiveMistakeCount = 0
}

// In this Cline request loop, we need to check if this task instance
// has been asked to wait for a subtask to finish before continuing.
// Check if this task is paused (waiting for a subtask)
// The child task will directly resume this task when it completes
const provider = this.providerRef.deref()

if (this.isPaused && provider) {
provider.log(`[subtasks] paused ${this.taskId}.${this.instanceId}`)
await this.waitForResume()
provider.log(`[subtasks] resumed ${this.taskId}.${this.instanceId}`)
const currentMode = (await provider.getState())?.mode ?? defaultModeSlug

if (currentMode !== this.pausedModeSlug) {
// The mode has changed, we need to switch back to the paused mode.
await provider.handleModeSwitch(this.pausedModeSlug)

// Delay to allow mode change to take effect before next tool is executed.
await delay(500)

provider.log(
`[subtasks] task ${this.taskId}.${this.instanceId} has switched back to '${this.pausedModeSlug}' from '${currentMode}'`,
)
}
provider.log(
`[subtasks] task ${this.taskId}.${this.instanceId} is paused, waiting for child task to complete`,
)
// The task will be resumed directly by the child task calling resumePausedTask()
// No polling needed - execution will continue when resumed
return true // Exit the loop while paused
Copy link
Contributor Author

@roomote roomote bot Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the early return intentional here? When a task is paused, returning true will exit the loop in initiateTaskLoop(). This might leave the task in a stuck state if the child never completes. Consider documenting this behavior more clearly.

}

// Getting verbose details is an expensive operation, it uses ripgrep to
Expand Down
Loading