Skip to content

fix: initialize enableReasoningEffort default value to fix save butto… #7100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: initialize enableReasoningEffort default value to fix save butto… #7100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions webview-ui/src/components/settings/ThinkingBudget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,15 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
? Math.min(modelInfo.maxThinkingTokens, Math.floor(0.8 * customMaxOutputTokens))
: Math.floor(0.8 * customMaxOutputTokens)

// Ensure enableReasoningEffort has a default value of false to prevent initial sync issues.
// This fixes the save button not enabling when user first checks the reasoning checkbox,
// by converting undefined to false so the change detection logic works correctly.
useEffect(() => {
if (isReasoningBudgetSupported && enableReasoningEffort === undefined) {
setApiConfigurationField("enableReasoningEffort", false)
}
}, [isReasoningBudgetSupported, enableReasoningEffort, setApiConfigurationField])

// If the custom max thinking tokens are going to exceed it's limit due
// to the custom max output tokens being reduced then we need to shrink it
// appropriately.
Expand Down
Loading