fix: enable Save button when clicking "Enable reasoning" checkbox

[roomote]

Summary

This PR fixes an issue where the Save button in the Settings view does not become enabled when the user clicks the "Enable reasoning" checkbox.

Problem

When enableReasoningEffort is initially undefined and the user clicks the checkbox to enable it, the transition from undefined to true was incorrectly treated as an "initial sync" in the setApiConfigurationField function. This prevented the Save button from being enabled because the change was not detected.

Solution

The fix explicitly excludes enableReasoningEffort from the initial sync logic since it is a user-controlled checkbox that should always trigger changes when toggled.

Changes Made

• Modified webview-ui/src/components/settings/SettingsView.tsx to exclude enableReasoningEffort from the initial sync condition

Testing

• All existing tests pass
• The Save button now correctly enables when clicking the "Enable reasoning" checkbox

Fixes #7099

---

Important

Fixes issue in SettingsView.tsx where the Save button does not enable when the "Enable reasoning" checkbox is clicked by excluding it from initial sync logic.

• Behavior:
  • Fixes issue where Save button does not enable when "Enable reasoning" checkbox is clicked.
  • Excludes enableReasoningEffort from initial sync logic in setApiConfigurationField() in SettingsView.tsx.
• Testing:
  • All existing tests pass.
  • Save button enables correctly when "Enable reasoning" checkbox is toggled.

^{This description was created by for 5d8e667. You can customize this summary. It will automatically update as commits are pushed.}

[wjq990112]

This is not a robust solution, so I created a PR #7100 to fix it. Pls merge that PR first.

[roomote]

Reviewing my own code is like debugging in a mirror - everything looks backwards and I still can't find the problem.

[roomote]

While this fix works for enableReasoningEffort, I found several other checkbox fields that might suffer from the same undefined → true transition issue:

• anthropicBeta1MContext
• awsBedrock1MContext
• enableUrlContext
• enableGrounding
• lmStudioSpeculativeDecodingEnabled
• openAiLegacyFormat

Should we investigate if these need the same treatment? Or perhaps consider a more scalable solution like maintaining a Set of user-controlled fields?

[roomote]

Is this approach intentional? Hard-coding field names here creates a maintenance burden. Could we consider using a more maintainable pattern like:

Suggested change

	const isInitialSync =
	// Don't treat initial sync from undefined to a defined value as a user change
	// This prevents the dirty state when the component initializes and auto-syncs the model ID
	// Exception: user-controlled checkboxes that should always trigger changes
	const USER_CONTROLLED_FIELDS = new Set(['enableReasoningEffort'])
	const isInitialSync =
	previousValue === undefined && value !== undefined && !USER_CONTROLLED_FIELDS.has(field)

[daniel-lxs]

Fixed by #7113