Skip to content

fix: enable Save button when clicking "Enable reasoning" checkbox #7101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: enable Save button when clicking "Enable reasoning" checkbox #7101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion webview-ui/src/components/settings/SettingsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,9 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t

// Don't treat initial sync from undefined to a defined value as a user change
// This prevents the dirty state when the component initializes and auto-syncs the model ID
const isInitialSync = previousValue === undefined && value !== undefined
// Exception: enableReasoningEffort is a user-controlled checkbox that should always trigger changes
const isInitialSync =
Copy link
Contributor Author

@roomote roomote bot Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this approach intentional? Hard-coding field names here creates a maintenance burden. Could we consider using a more maintainable pattern like:

Suggested change
const isInitialSync =
// Don't treat initial sync from undefined to a defined value as a user change
// This prevents the dirty state when the component initializes and auto-syncs the model ID
// Exception: user-controlled checkboxes that should always trigger changes
const USER_CONTROLLED_FIELDS = new Set(['enableReasoningEffort'])
const isInitialSync =
previousValue === undefined && value !== undefined && !USER_CONTROLLED_FIELDS.has(field)

previousValue === undefined && value !== undefined && field !== "enableReasoningEffort"
Copy link
Contributor Author

@roomote roomote bot Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this fix works for enableReasoningEffort, I found several other checkbox fields that might suffer from the same undefined → true transition issue:

  • anthropicBeta1MContext
  • awsBedrock1MContext
  • enableUrlContext
  • enableGrounding
  • lmStudioSpeculativeDecodingEnabled
  • openAiLegacyFormat

Should we investigate if these need the same treatment? Or perhaps consider a more scalable solution like maintaining a Set of user-controlled fields?


if (!isInitialSync) {
setChangeDetected(true)
Expand Down
Loading