feat: remove assistantMessageParser experiment flag and enable for all users #7300
Conversation
…l users - Remove assistantMessageParser from experiment definitions in packages/types - Remove ASSISTANT_MESSAGE_PARSER from shared experiments configuration - Update Task.ts to always initialize and use AssistantMessageParser - Remove conditional logic that checked for experiment flag - Remove unused parseAssistantMessage import - Update test files to remove assistantMessageParser references - All tests passing successfully
dosubot
bot
added
the
size:M
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| import { RooIgnoreController } from "../ignore/RooIgnoreController" | ||
| import { RooProtectedController } from "../protect/RooProtectedController" | ||
| import { type AssistantMessageContent, presentAssistantMessage, parseAssistantMessage } from "../assistant-message" | ||
| import { type AssistantMessageContent, presentAssistantMessage } from "../assistant-message" |
There was a problem hiding this comment.
The import statement still includes parseAssistantMessage which is no longer used after this refactor. Could we clean this up?
| "preventFocusDisruption", | ||
| "assistantMessageParser", | ||
| ] as const | ||
| export const experimentIds = ["powerSteering", "multiFileApplyDiff", "preventFocusDisruption"] as const |
There was a problem hiding this comment.
Since this removes an experimental flag and makes the feature default for all users, should we consider adding a note about any potential impacts on existing users who may have had the experiment disabled? Perhaps in the PR description or as a comment here?
| } | ||
|
|
||
| // Initialize the assistant message parser | ||
| this.assistantMessageParser = new AssistantMessageParser() |
There was a problem hiding this comment.
Now that AssistantMessageParser is enabled for all users, could we verify that it has adequate test coverage? The existing tests have been updated to remove the experiment references, but it would be good to ensure the parser functionality itself is well-tested.
hannesrudolph
added
the
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
This PR removes the
assistantMessageParserexperimental flag and enables the AssistantMessageParser functionality for all users.Changes Made
assistantMessageParserfrom experiment definitions inpackages/types/src/experiment.tsASSISTANT_MESSAGE_PARSERfrom shared experiments configuration insrc/shared/experiments.tsTask.tsto always initialize and useAssistantMessageParserparseAssistantMessageimportassistantMessageParserreferencesTesting
All tests have been run and are passing:
src/shared/__tests__/experiments.spec.ts✅webview-ui/src/context/__tests__/ExtensionStateContext.spec.tsx✅src/core/task/__tests__/Task.spec.ts✅Type Safety
Type checking has been completed successfully across all packages.
Context
This change was requested via Slack to promote the experimental
assistantMessageParserfeature to production, making it available for all users by default.Important
Remove
assistantMessageParserexperiment flag and enableAssistantMessageParserfor all users.assistantMessageParserexperiment flag fromexperiment.tsandexperiments.ts.Task.tsto always initialize and useAssistantMessageParser.assistantMessageParserinTask.ts.experiments.spec.tsandExtensionStateContext.spec.tsxto removeassistantMessageParserreferences.parseAssistantMessageimport inTask.ts.This description was created by
for 73fd577. You can customize this summary. It will automatically update as commits are pushed.