Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Aug 21, 2025

Important

Passes task ID in Roo provider request headers and updates tests to accommodate new request options parameter.

  • Behavior:
    • Passes taskId in request headers as X-Roo-Task-ID in RooHandler.
    • Updates createStream in base-openai-compatible-provider.ts to accept requestOptions.
  • Tests:
    • Adds undefined as a parameter in createMessage calls in chutes.spec.ts, fireworks.spec.ts, groq.spec.ts, roo.spec.ts, sambanova.spec.ts, and zai.spec.ts to accommodate new requestOptions parameter.

This description was created by Ellipsis for 9049272. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners August 21, 2025 23:09
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found some issues that need attention. The implementation adds the task ID header to streaming requests, but there are a few gaps that should be addressed for completeness.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 21, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 21, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Aug 22, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Aug 22, 2025
@cte cte merged commit 175edef into main Aug 22, 2025
13 checks passed
@cte cte deleted the cte/pass-task-id-in-header branch August 22, 2025 03:27
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Aug 22, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Preliminary Review size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants