Skip to content

fix: enable checkpoints for SQL files #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: enable checkpoints for SQL files #7311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/services/checkpoints/__tests__/excludes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ readme.md text
expect(excludePatterns).toContain("*.db") // database
expect(excludePatterns).toContain("*.shp") // geospatial
expect(excludePatterns).toContain("*.log") // log

// Verify SQL files are NOT excluded (fix for issue #7310)
expect(excludePatterns).not.toContain("*.sql")
})

it("should handle errors when reading .gitattributes", async () => {
Expand Down Expand Up @@ -150,6 +153,9 @@ readme.md text
expect(excludePatterns).toContain("*.db") // database
expect(excludePatterns).toContain("*.shp") // geospatial
expect(excludePatterns).toContain("*.log") // log

// Verify SQL files are NOT excluded (fix for issue #7310)
expect(excludePatterns).not.toContain("*.sql")
})
})
})
1 change: 0 additions & 1 deletion src/services/checkpoints/excludes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ const getDatabaseFilePatterns = () => [
"*.parquet",
"*.pdb",
"*.rdb",
"*.sql",
"*.sqlite",
Copy link
Contributor Author

@roomote roomote bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Removing SQL files from exclusions makes sense since they're text-based scripts users actively edit. However, two considerations:

  1. Large SQL dumps: Some SQL files can be multi-gigabyte database dumps. Users should add these to .gitignore if needed.

  2. CSV consistency: I noticed CSV files (*.csv) are still excluded in this list, but they're also text files users might edit. Should we consider removing CSV from exclusions for consistency?

  3. Documentation: Consider adding a comment above getDatabaseFilePatterns() explaining it excludes binary database files but not SQL scripts.

]

Expand Down
Loading