From b0ee56d49fdb39ac217c0580a81db88871f261c7 Mon Sep 17 00:00:00 2001 From: Matt Rubens Date: Fri, 29 Aug 2025 23:42:07 -0400 Subject: [PATCH 1/2] Handle images in roolease notes --- .github/workflows/marketplace-publish.yml | 4 ++++ .roo/commands/release.md | 1 + 2 files changed, 5 insertions(+) diff --git a/.github/workflows/marketplace-publish.yml b/.github/workflows/marketplace-publish.yml index aef91b2d32..697638f9b9 100644 --- a/.github/workflows/marketplace-publish.yml +++ b/.github/workflows/marketplace-publish.yml @@ -81,6 +81,10 @@ jobs: changelog_content="Release v${current_package_version}" else echo "Found changelog section for version ${current_package_version}" + # Convert relative image paths to full GitHub URLs for proper display in release notes + # Use the main branch URL since the images will be merged there before release + # Only match .png files to avoid accidentally modifying other references + changelog_content=$(echo "$changelog_content" | sed "s|(releases/\([^)]*\.png\))|(https://github.com/${{ github.repository }}/raw/main/releases/\1)|g") fi # Create release with changelog content diff --git a/.roo/commands/release.md b/.roo/commands/release.md index 99c6d3a9f9..50302c6789 100644 --- a/.roo/commands/release.md +++ b/.roo/commands/release.md @@ -41,4 +41,5 @@ argument-hint: patch | minor | major 11. The GitHub Actions workflow will automatically: - Create a version bump PR when changesets are merged to main - Update the CHANGELOG.md with proper formatting + - Convert PNG image paths in release notes to GitHub raw URLs for proper display - Publish the release when the version bump PR is merged From f8051e82beb125396f36230b9e9406195038a997 Mon Sep 17 00:00:00 2001 From: Matt Rubens Date: Sat, 30 Aug 2025 00:14:34 -0400 Subject: [PATCH 2/2] More image types --- .github/workflows/marketplace-publish.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/marketplace-publish.yml b/.github/workflows/marketplace-publish.yml index 697638f9b9..5ab1ddb6e5 100644 --- a/.github/workflows/marketplace-publish.yml +++ b/.github/workflows/marketplace-publish.yml @@ -83,8 +83,9 @@ jobs: echo "Found changelog section for version ${current_package_version}" # Convert relative image paths to full GitHub URLs for proper display in release notes # Use the main branch URL since the images will be merged there before release - # Only match .png files to avoid accidentally modifying other references - changelog_content=$(echo "$changelog_content" | sed "s|(releases/\([^)]*\.png\))|(https://github.com/${{ github.repository }}/raw/main/releases/\1)|g") + # Match common image file extensions: png, jpg, jpeg, gif, webp, svg + # Using extended regex (-E) for better portability + changelog_content=$(echo "$changelog_content" | sed -E "s/\(releases\/([^)]*\.(png|jpg|jpeg|gif|webp|svg))\)/(https:\/\/github.com\/${{ github.repository }}\/raw\/main\/releases\/\1)/g") fi # Create release with changelog content