fix: prevent countdown timer from showing in history for answered follow-up questions #7625
Conversation
…low-up questions - Check if follow-up question has been answered by looking for subsequent messages - For current session, use existing currentFollowUpTs check - For history, check if there are messages after the follow-up question - Fixes #7624
dosubot
bot
added
size:S
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // Check if this follow-up question has been answered | ||
| // For current session: check if it matches currentFollowUpTs | ||
| // For history: check if there's a message after this follow-up question | ||
| const isFollowUpAnswered = (() => { |
There was a problem hiding this comment.
I notice this logic is duplicated from what appears around line 1521. Could we extract this into a reusable function to follow DRY principles? Something like:
| } | ||
| // For historical messages, check if there's a message after this follow-up | ||
| // If there is, it means the follow-up was answered | ||
| const messageIndex = modifiedMessages.findIndex((msg) => msg.ts === messageOrGroup.ts) |
There was a problem hiding this comment.
Using on for every render could impact performance with large message lists. Have you considered memoizing this check or perhaps storing the answered state in a more efficient data structure?
| // If there is, it means the follow-up was answered | ||
| const messageIndex = modifiedMessages.findIndex((msg) => msg.ts === messageOrGroup.ts) | ||
| if (messageIndex !== -1 && messageIndex < modifiedMessages.length - 1) { | ||
| // There's at least one message after this follow-up, so it was answered |
There was a problem hiding this comment.
The current logic assumes any message after a follow-up means it was answered. What if there's an error message or system message immediately after? Should we verify the next message is actually a user response or an action that indicates the follow-up was handled?
|
|
||
| // regular message | ||
| // Check if this follow-up question has been answered | ||
| // For current session: check if it matches currentFollowUpTs |
There was a problem hiding this comment.
These comments are helpful but could be more concise. Consider combining them:
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Description
This PR fixes an issue where the countdown timer would incorrectly reappear when viewing task history, even after a follow-up suggestion had been selected.
Problem
When users:
The countdown timer would incorrectly show again in the history view, even though the suggestion had already been selected.
Solution
The fix adds logic to properly determine if a follow-up question has been answered:
currentFollowUpTscheckTesting
Related Issue
Fixes #7624
Review Confidence
The implementation review showed 95% confidence with no security issues or code quality concerns.
Important
Fixes countdown timer reappearing in task history for answered follow-up questions by adding logic in
ChatView.tsx.ChatView.tsxto check if a follow-up question is answered by verifyingcurrentFollowUpTsfor current sessions and checking subsequent messages for historical ones.This description was created by
for 4fc9982. You can customize this summary. It will automatically update as commits are pushed.