fix: Address todo list advanced settings feedback #7809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary todoListEnabled migration logic (no backfill needed) - Fix Advanced Settings text wrapping with proper CSS classes - Temperature and rate limit controls already under advanced settings
roo-code-preview
bot
requested review from
cte,
jr and
mrubens
as code owners
dosubot
bot
added
size:M
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| <span className="font-medium">{t("settings:advancedSettings.title")}</span> | ||
| <CollapsibleTrigger className="flex items-center gap-2 w-full cursor-pointer hover:opacity-80 mb-2"> | ||
| <span | ||
| className={`codicon codicon-chevron-${isAdvancedSettingsOpen ? "down" : "right"} flex-shrink-0`}></span> |
Contributor
There was a problem hiding this comment.
Nice fix for the text wrapping issue! The combination of flex-shrink-0 on the chevron and whitespace-nowrap on the text should prevent the Advanced Settings label from breaking onto multiple lines. The gap-2 also provides better visual spacing than gap-1.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the feedback from @mrubens on issue #5624:
Changes Made
✅ 1. Remove unnecessary migration logic (no backfill needed)
todoListEnabledMigratedfrom provider settings schemamigrateTodoListEnabledmethod from ProviderSettingsManager✅ 3. Fix "Advanced Settings" text wrapping issue
flex-shrink-0andwhitespace-nowrapCSS classes to prevent text wrappinggap-2instead ofgap-1❓ 2. Temperature and rate limit controls placement
The temperature and rate limit controls are already under the Advanced Settings toggle (lines 768-778 in ApiOptions.tsx). If this needs to be moved to a different location, please clarify where they should be positioned.
Testing
This PR attempts to address Issue #5624. Please let me know if the temperature/rate limit placement needs further adjustment.
Important
Removed unnecessary migration logic and fixed text wrapping in advanced settings UI.
todoListEnabledMigratedfromproviderProfilesSchemainProviderSettingsManager.ts.migrateTodoListEnabledmethod fromProviderSettingsManager.ProviderSettingsManager.spec.ts.flex-shrink-0andwhitespace-nowrapclasses toCollapsibleTriggerinApiOptions.tsxto fix text wrapping.gap-1togap-2inApiOptions.tsx.This description was created by
for 8e077a2. You can customize this summary. It will automatically update as commits are pushed.