Skip to content

fix: auto-insert space before @mentions when needed #8064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: auto-insert space before @mentions when needed #8064

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
134338c
fix: auto-insert space before @mentions when needed
roomote Sep 17, 2025
dbf6a7d
test: fix context-mentions tests after auto-space feature
daniel-lxs Sep 19, 2025
7ca6046
test: update context-mentions tests for auto-space feature
daniel-lxs Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions webview-ui/src/components/chat/ChatTextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,15 @@ export const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
let newValue = inputValue.slice(0, cursorPosition)
let totalLength = 0

// Check if we need to add a space before the first mention
const textBefore = inputValue.slice(0, cursorPosition)
Copy link
Contributor Author

@roomote roomote bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This space-checking logic is duplicated in the insertMention function. Since insertMention already handles adding space before @mentions, do we need this logic here as well?

Consider whether both places need this or if it should be centralized in one location to avoid potential inconsistencies.

const needsSpaceBefore =
textBefore.length > 0 && !textBefore.endsWith(" ") && !textBefore.endsWith("\n")
if (needsSpaceBefore) {
newValue += " "
totalLength += 1
}

// Using a standard for loop instead of forEach for potential performance gains.
for (let i = 0; i < lines.length; i++) {
const line = lines[i]
Expand Down
Loading
Loading