Skip to content

fix: rehydrate parent task when resuming subtask after interruption #8090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: rehydrate parent task when resuming subtask after interruption #8090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions src/core/webview/ClineProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,12 +451,32 @@ export class ClineProvider
// This is used when a subtask is finished and the parent task needs to be
// resumed.
async finishSubTask(lastMessage: string) {
Copy link
Contributor Author

@roomote roomote bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation of the minimal fix! The rehydration logic is clean and handles the edge cases well. Consider adding JSDoc comments to document this new behavior for future maintainers:

// Store the parent task ID before removing the child
const parentTaskId = this.getCurrentTask()?.parentTaskId

// Remove the last cline instance from the stack (this is the finished
// subtask).
await this.removeClineFromStack()
// Resume the last cline instance in the stack (if it exists - this is
// the 'parent' calling task).
await this.getCurrentTask()?.completeSubtask(lastMessage)

// Try to get the parent task from the stack
let parentTask = this.getCurrentTask()

// If parent is not on the stack but we have a parentTaskId, rehydrate it
if (!parentTask && parentTaskId) {
try {
const { historyItem } = await this.getTaskWithId(parentTaskId)
// Create the parent task from history
parentTask = await this.createTaskWithHistoryItem(historyItem)
this.log(`[finishSubTask] Rehydrated parent task ${parentTaskId} from history`)
Copy link
Contributor Author

@roomote roomote bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider extracting the '[finishSubTask]' prefix to a constant since it's used multiple times in the logging statements. This would ensure consistency and make future changes easier:

Rehydrated parent task from history

} catch (error) {
this.log(`[finishSubTask] Failed to rehydrate parent task ${parentTaskId}: ${error}`)
// If we can't rehydrate the parent, at least log the error
// The UI will remain in a state where the user can start a new task
}
}

// Resume the parent task (if it exists)
await parentTask?.completeSubtask(lastMessage)
}
// Pending Edit Operations Management

Expand Down
Loading
Loading