-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add a list of sub-processors #8163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Preview deployed! Your changes have been deployed to Vercel: Preview URL: https://roo-code-website-9si6awylo-roo-code.vercel.app This preview will be updated automatically when you push new commits to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and found a critical issue with the date that needs attention, along with some suggestions for improvement.
| <> | ||
| <div className="container mx-auto px-4 py-12 sm:px-6 lg:px-8"> | ||
| <div className="prose prose-lg mx-auto max-w-5xl dark:prose-invert"> | ||
| <p className="text-muted-foreground">Updated: September 18, 2025</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this date intentional? It shows "September 18, 2025" but we're currently in 2024. This could confuse users about when the subprocessor list was last updated.
| return ( | ||
| <> | ||
| <div className="container mx-auto px-4 py-12 sm:px-6 lg:px-8"> | ||
| <div className="prose prose-lg mx-auto max-w-5xl dark:prose-invert"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the terms page uses while this uses . Should we maintain consistency across legal pages?
| <p className="lead">Roo Code engages the following third parties to process Customer Data.</p> | ||
|
|
||
| <div className="overflow-x-auto"> | ||
| <table className="min-w-full border-collapse border border-border"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be helpful to add a caption or aria-label to improve accessibility for screen reader users?
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered extracting this subprocessor data into a separate configuration file or constant? It might make future updates easier to manage, especially as the list grows.
| </li> | ||
| <li> | ||
| <Link | ||
| href="/legal/subprocessors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the best placement for the Subprocessors link? Would it make more sense to group it closer to the Terms of Service link (line 217) since they're both legal documents?
Important
Adds a new page listing subprocessors and updates the footer to include a link to this page.
page.tsxto list third-party subprocessors used by Roo Code.footer.tsx.This description was created by
for 73f5223. You can customize this summary. It will automatically update as commits are pushed.