feat: add CloudAccountSwitcher component for switching between cloud accounts #8221
Conversation
…accounts - Created CloudAccountSwitcher component that displays current account icon - Added tooltip with 'Switch Roo Cloud Account' text (localized) - Component only visible when user has 2+ accounts (multiple orgs or org + personal) - Integrated into ChatTextArea next to IndexingStatusBadge - Added rooCloudAccountSwitch message handler for account switching - Exposed organization memberships through CloudService and ClineProvider - Added translation keys for all supported locales - Account switching redirects to /switch landing page after logout - Fixed all linting issues
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| "taskList": "Roo Code Cloud ist hier: Verfolge und kontrolliere deine Aufgaben von überall. <learnMoreLink>Mehr erfahren</learnMoreLink>." | ||
| } | ||
| }, | ||
| "switchAccount": "Switch Roo Cloud Account" |
There was a problem hiding this comment.
Notice: The new key 'switchAccount' uses an English message ('Switch Roo Cloud Account') in the German locale file. If this isn’t intentional, please translate it into German before merging.
| "switchAccount": "Switch Roo Cloud Account" | |
| "switchAccount": "Roo Cloud Konto wechseln" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "testApiAuthentication": "Test API Authentication", | ||
| "signIn": "Connect to Roo Code Cloud", | ||
| "connect": "Get started", | ||
| "switchAccount": "Switch Roo Cloud Account", |
There was a problem hiding this comment.
Typographical suggestion: The new label "Switch Roo Cloud Account" appears to be inconsistent with other entries that reference "Roo Code Cloud" (e.g., "Connect to Roo Code Cloud"). If this is unintentional, consider updating it to "Switch Roo Code Cloud Account" for consistency.
| "switchAccount": "Switch Roo Cloud Account", | |
| "switchAccount": "Switch Roo Code Cloud Account", |
This comment was generated because it violated the following rules: irule_C0ez7Rji6ANcGkkX and irule_VrRKWqywZ2YV2SOE.
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| if (organizationMemberships.length >= 2) return true | ||
|
|
||
| // If user has at least one org membership, they also have personal account access | ||
| if (organizationMemberships.length >= 1) return true |
There was a problem hiding this comment.
Visibility logic concern: This component will show for users with just one organization membership, even if they can't actually switch to a personal account. Consider adding a check to verify if users can actually switch between accounts (e.g., check if personal account access is available).
| if (organizationMemberships.length >= 1) return true | |
| // If user has at least one org membership, they also have personal account access | |
| if (organizationMemberships.length >= 1) { | |
| // TODO: Verify if user can actually switch to personal account | |
| // This assumes all users with org memberships also have personal account access | |
| return true | |
| } |
| "taskList": "Roo Code Cloud ja és aquí: segueix i controla les teves tasques des de qualsevol lloc. <learnMoreLink>Més informació</learnMoreLink>." | ||
| } | ||
| }, | ||
| "switchAccount": "Switch Roo Cloud Account" |
There was a problem hiding this comment.
Missing translation: The "Switch Roo Cloud Account" text should be translated to Catalan instead of being hardcoded in English.
| if (CloudService.hasInstance() && CloudService.instance.isAuthenticated()) { | ||
| cloudOrganizationMemberships = await CloudService.instance.getOrganizationMemberships() | ||
| } | ||
| } catch (error) { |
There was a problem hiding this comment.
Error handling: Consider showing a degraded UI state if fetching organization memberships fails, rather than just logging the error. Users might wonder why the account switcher isn't appearing.
|
|
||
| public async getOrganizationMemberships(): Promise<CloudOrganizationMembership[]> { | ||
| this.ensureInitialized() | ||
| if (this.authService && "getOrganizationMemberships" in this.authService) { |
There was a problem hiding this comment.
Type safety: Consider using a more explicit interface check instead of duck typing with the 'in' operator. You could define an interface that includes getOrganizationMemberships method.
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
|
Closing, this feature was merged |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
This PR adds a new CloudAccountSwitcher component to the ChatTextArea that allows users to switch between multiple cloud accounts (personal and organization accounts).
Changes
Testing
Implementation review: 92% confidence - Ready for production
Important
Introduces
CloudAccountSwitchercomponent for switching between cloud accounts inChatTextArea, with localization and message handling support.CloudAccountSwitchercomponent toChatTextAreafor switching between cloud accounts./switchlanding page after logout.CloudAccountSwitchernext toIndexingStatusBadgeinChatTextArea.tsx.rooCloudAccountSwitchmessage handler inwebviewMessageHandler.ts.switchAccountfor all supported locales incloud.jsonfiles.CloudServiceandClineProvider.This description was created by
for 2ccdf60. You can customize this summary. It will automatically update as commits are pushed.