-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: add GLM 4.5 Air models to OpenRouter reasoning budget models #8314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added z-ai/glm-4.5-air and z-ai/glm-4.5-air:free to OPEN_ROUTER_REASONING_BUDGET_MODELS - These models support reasoning parameters as confirmed by OpenRouter API - Fixes issue where GLM 4.5 Air models were not appearing in chat interface Fixes #8313
- Added z-ai/glm-4.5-air and z-ai/glm-4.5-air:free to excludedReasoningBudgetModels - These models are not yet in the test fixture but are available in the live API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review protocol engaged: judging my own code with the same warmth I reserve for null pointers.
| "google/gemini-2.5-flash", | ||
| "google/gemini-2.5-flash-lite-preview-06-17", | ||
| "z-ai/glm-4.5-air", | ||
| "z-ai/glm-4.5-air:free", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Consider adding a short note (or link to OpenRouter docs/changelog) explaining that GLM 4.5 Air supports the reasoning parameter and why we include it here. This helps future readers verify intent without re-checking the API.
| "google/gemini-2.5-pro", | ||
| "anthropic/claude-opus-4.1", // Not yet available in OpenRouter API | ||
| "z-ai/glm-4.5-air", // Not yet in test fixture | ||
| "z-ai/glm-4.5-air:free", // Not yet in test fixture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Suggest turning this into a TODO with a removal condition, e.g., TODO: Remove once OpenRouter fixtures include GLM 4.5 Air models so we can assert them directly. This makes the follow-up action explicit.
|
This is not the right solution. |
This PR addresses Issue #8313 by enabling the GLM 4.5 Air models from OpenRouter to support thinking/reasoning capabilities in the chat interface.
Changes
z-ai/glm-4.5-airandz-ai/glm-4.5-air:freetoOPEN_ROUTER_REASONING_BUDGET_MODELSsetWhy these changes are needed
The GLM 4.5 Air models from OpenRouter support the
reasoningparameter as confirmed by the OpenRouter API, but were not included in the reasoning budget models configuration. This prevented users from using the thinking/reasoning features with these models in the chat interface.Testing
Fixes #8313
Important
Add GLM 4.5 Air models to reasoning budget models and update tests to exclude them from fixture validation.
z-ai/glm-4.5-airandz-ai/glm-4.5-air:freetoOPEN_ROUTER_REASONING_BUDGET_MODELSinopenrouter.ts.openrouter.spec.tsto exclude these models from fixture validation.This description was created by
for d381fde. You can customize this summary. It will automatically update as commits are pushed.