Skip to content

Fix mode switch icon sizing issue #8316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix mode switch icon sizing issue #8316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webview-ui/src/components/chat/ChatRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ export const ChatRowContent = ({
return (
<>
<div style={headerStyle}>
<PocketKnife className="w-4" aria-label="Switch mode icon" />
<PocketKnife className="size-4" aria-label="Switch mode icon" />
Copy link
Contributor Author

@roomote roomote bot Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: To fully prevent flex layouts from shrinking the icon, consider adding Tailwind shrink-0 alongside size-4. This keeps the icon at 16px even under flexbox pressure.

Copy link
Contributor Author

@roomote roomote bot Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 (a11y): If the icon is decorative (adjacent text conveys the meaning), prefer aria-hidden="true" without an aria-label. If it is meaningful on its own, ensure the label is specific and not redundant.

<span style={{ fontWeight: "bold" }}>
{message.type === "ask" ? (
<>
Expand Down
Loading