feat(rate-limit): better feedback in chat #8503
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| let rateLimitDelay = 0 | ||
|
|
||
| const sendRateLimitUpdate = async (payload: RateLimitRetryPayload, isPartial: boolean): Promise<void> => { | ||
| await this.say("api_req_retry_delayed", undefined, undefined, isPartial, undefined, undefined, { |
There was a problem hiding this comment.
[P2] Mark rate-limit status updates as non-interactive
api_req_retry_delayed is a UI-only status row and shouldn't mutate lastMessageTs. Currently sendRateLimitUpdate calls say() without isNonInteractive, which updates lastMessageTs for new messages in say(). This can interfere with Task.ask's blocking/waiting logic if a status update races with an ask.
Setting isNonInteractive true keeps the message ordering/UI unchanged while avoiding unintended ask lifecycle interactions.
Suggested change
| await this.say("api_req_retry_delayed", undefined, undefined, isPartial, undefined, undefined, { | |
| await this.say("api_req_retry_delayed", undefined, undefined, isPartial, undefined, undefined, { | |
| isNonInteractive: true, | |
| metadata: { rateLimitRetry: payload }, | |
| }) |
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
force-pushed
the
feat/rate-limit-ui
branch
from
8f87a11 to
0b42d73
Compare
dosubot
bot
added
size:XL
|
Reviewed PR #8503. All previously identified issues have been resolved.
Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
dosubot
bot
added
size:L
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #7922
Roo Code Task Context (Optional)
Description
This PR adds a more user friendly UI to display error caused by rate limit.
Test Procedure
Added a test file along with manual instructions.
Pre-Submission Checklist
Screenshots / Videos
Screen.Recording.2025-10-04.at.15.49.48.mov
Documentation Updates
Additional Notes
Get in Touch
@elianiva
Important
Enhances chat UI with a user-friendly rate limit error display, including countdown and retry logic, and updates localization files for multiple languages.
RateLimitRetryRowcomponent inChatRow.tsxto display retry status.Task.tsto handle rate limit retries with countdown and retry logic.chat.jsonforid,it,ja,ko,nl,pl,pt-BR,ru,tr,vi,zh-CN, andzh-TW.RateLimitRetryRow.spec.tsxfor testing the new UI component.This description was created by
for 03909fc. You can customize this summary. It will automatically update as commits are pushed.