From 89a2b5ca36a66249f704dbeb8bdbe8522fd21556 Mon Sep 17 00:00:00 2001 From: Roo Code Date: Tue, 21 Oct 2025 18:51:33 +0000 Subject: [PATCH 1/2] feat: add GLM-4.6 model to Fireworks provider --- packages/types/src/providers/fireworks.ts | 11 ++++++++++ src/api/providers/__tests__/fireworks.spec.ts | 21 +++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/packages/types/src/providers/fireworks.ts b/packages/types/src/providers/fireworks.ts index 694ad0d12606..a2528fb67d9e 100644 --- a/packages/types/src/providers/fireworks.ts +++ b/packages/types/src/providers/fireworks.ts @@ -10,6 +10,7 @@ export type FireworksModelId = | "accounts/fireworks/models/deepseek-v3p1" | "accounts/fireworks/models/glm-4p5" | "accounts/fireworks/models/glm-4p5-air" + | "accounts/fireworks/models/glm-4p6" | "accounts/fireworks/models/gpt-oss-20b" | "accounts/fireworks/models/gpt-oss-120b" @@ -105,6 +106,16 @@ export const fireworksModels = { description: "Z.ai GLM-4.5-Air with 106B total parameters and 12B active parameters. Features unified reasoning, coding, and intelligent agent capabilities.", }, + "accounts/fireworks/models/glm-4p6": { + maxTokens: 16384, + contextWindow: 128000, + supportsImages: false, + supportsPromptCache: false, + inputPrice: 0.55, + outputPrice: 2.19, + description: + "Z.ai GLM-4.6 is an advanced coding model with exceptional performance on complex programming tasks. Features improved reasoning capabilities and enhanced code generation quality, making it ideal for software development workflows.", + }, "accounts/fireworks/models/gpt-oss-20b": { maxTokens: 16384, contextWindow: 128000, diff --git a/src/api/providers/__tests__/fireworks.spec.ts b/src/api/providers/__tests__/fireworks.spec.ts index f07c1797a05f..1697de33455f 100644 --- a/src/api/providers/__tests__/fireworks.spec.ts +++ b/src/api/providers/__tests__/fireworks.spec.ts @@ -242,6 +242,27 @@ describe("FireworksHandler", () => { ) }) + it("should return GLM-4.6 model with correct configuration", () => { + const testModelId: FireworksModelId = "accounts/fireworks/models/glm-4p6" + const handlerWithModel = new FireworksHandler({ + apiModelId: testModelId, + fireworksApiKey: "test-fireworks-api-key", + }) + const model = handlerWithModel.getModel() + expect(model.id).toBe(testModelId) + expect(model.info).toEqual( + expect.objectContaining({ + maxTokens: 16384, + contextWindow: 128000, + supportsImages: false, + supportsPromptCache: false, + inputPrice: 0.55, + outputPrice: 2.19, + description: expect.stringContaining("Z.ai GLM-4.6 is an advanced coding model"), + }), + ) + }) + it("should return gpt-oss-20b model with correct configuration", () => { const testModelId: FireworksModelId = "accounts/fireworks/models/gpt-oss-20b" const handlerWithModel = new FireworksHandler({ From 12467b54c3c73d659266728e0b942f66f3af1fc9 Mon Sep 17 00:00:00 2001 From: Roo Code Date: Tue, 21 Oct 2025 19:30:50 +0000 Subject: [PATCH 2/2] fix: update GLM-4.6 model configuration with correct specifications - Updated maxTokens from 16384 to 25344 - Updated contextWindow from 128000 to 198000 - Updated test expectations to match new specifications As requested by @mmealman in issue #8752 --- packages/types/src/providers/fireworks.ts | 4 ++-- src/api/providers/__tests__/fireworks.spec.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/types/src/providers/fireworks.ts b/packages/types/src/providers/fireworks.ts index a2528fb67d9e..88e1939c0243 100644 --- a/packages/types/src/providers/fireworks.ts +++ b/packages/types/src/providers/fireworks.ts @@ -107,8 +107,8 @@ export const fireworksModels = { "Z.ai GLM-4.5-Air with 106B total parameters and 12B active parameters. Features unified reasoning, coding, and intelligent agent capabilities.", }, "accounts/fireworks/models/glm-4p6": { - maxTokens: 16384, - contextWindow: 128000, + maxTokens: 25344, + contextWindow: 198000, supportsImages: false, supportsPromptCache: false, inputPrice: 0.55, diff --git a/src/api/providers/__tests__/fireworks.spec.ts b/src/api/providers/__tests__/fireworks.spec.ts index 1697de33455f..649729fc9c34 100644 --- a/src/api/providers/__tests__/fireworks.spec.ts +++ b/src/api/providers/__tests__/fireworks.spec.ts @@ -252,8 +252,8 @@ describe("FireworksHandler", () => { expect(model.id).toBe(testModelId) expect(model.info).toEqual( expect.objectContaining({ - maxTokens: 16384, - contextWindow: 128000, + maxTokens: 25344, + contextWindow: 198000, supportsImages: false, supportsPromptCache: false, inputPrice: 0.55,