-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Improve checkpoint menu translations for PR #7841 #8796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review SummaryI've reviewed the latest changes in this PR (commit ae0a084). The latest update improves translation consistency in the Chinese language file:
However, the test expectation issues remain unresolved: Issues to Fix
|
…pdate tooltip text in ChatRow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. Found 1 issue that should be addressed before approval. See inline comments for details.
Co-authored-by: Bruno Bergher <[email protected]>
094c272 to
91689d4
Compare
- Add missing 'checkpoint.menu.more' translation key for accessibility - Add translation keys for checkpoint diff messages (no_first, no_previous, no_changes, diff_with_next, diff_since_first, diff_to_current) - Fix English wording: 'compared with' instead of 'compare with' - Fix naming inconsistency: rename setRestoreIsConfirming to setRestoreConfirming - Update tests to expect translation keys instead of hardcoded strings - All translations added to 18 supported languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. There are still unresolved test issues that need to be addressed before approval.
Related GitHub Issue
This PR improves the translations for PR #7841
Description
The original PR #7841 added new checkpoint diff viewing modes but the English translations were unclear:
These new translations are clearer and tell users exactly what each button does:
All language translations have been updated accordingly.
Test Procedure
Pre-Submission Checklist
Important
This PR updates translations for checkpoint menu options across multiple languages and adjusts tests to reflect these changes.
chat.jsonfiles for multiple languages includingca,de,en,es,fr,hi,id,it,ja,ko,nl,pl,pt-BR,ru,tr,vi,zh-CN,zh-TW.checkpoint.test.tsto reflect new translation keys.WebviewMessage.tsto include new translation keys for checkpoint diff options.This description was created by
for 4aa6ee5. You can customize this summary. It will automatically update as commits are pushed.