Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Oct 23, 2025

Related GitHub Issue

This PR improves the translations for PR #7841

Description

The original PR #7841 added new checkpoint diff viewing modes but the English translations were unclear:

  • "View Diff With First Checkpoint" → "View All Changes"
  • "View Diff With Current Workspace" → "View Changes Since This Checkpoint"

These new translations are clearer and tell users exactly what each button does:

  • "View All Changes" - Shows all accumulated changes from the first checkpoint to the selected one
  • "View Changes Since This Checkpoint" - Shows what has changed from this checkpoint to the current workspace state

All language translations have been updated accordingly.

Test Procedure

  1. Enable checkpoints in settings
  2. Create a task with file modifications to generate checkpoints
  3. Click the "more" button (three dots) on any checkpoint
  4. Verify the two new button labels are clear and descriptive

Pre-Submission Checklist

  • Issue Linked: This PR improves translations for PR Enhance Diff View #7841
  • Scope: My changes are focused on improving translations only
  • Self-Review: I have performed a thorough self-review of my code
  • Testing: All language files have been updated with appropriate translations
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines

Important

This PR updates translations for checkpoint menu options across multiple languages and adjusts tests to reflect these changes.

  • Translations:
    • Update translations for checkpoint menu options in chat.json files for multiple languages including ca, de, en, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW.
    • New translations for "View All Changes" and "View Changes Since This Checkpoint".
  • Tests:
    • Update checkpoint.test.ts to reflect new translation keys.
    • Modify test descriptions and expected values to match updated translations.
  • Misc:
    • Update WebviewMessage.ts to include new translation keys for checkpoint diff options.

This description was created by Ellipsis for 4aa6ee5. You can customize this summary. It will automatically update as commits are pushed.

@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners October 23, 2025 21:50
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Documentation Improvements or additions to documentation labels Oct 23, 2025
@roomote
Copy link
Contributor

roomote bot commented Oct 23, 2025

Review Summary

I've reviewed the latest changes in this PR (commit ae0a084). The latest update improves translation consistency in the Chinese language file:

  • Missing translation key chat:checkpoint.menu.more - Fixed in previous commits
  • Updated zh-CN/common.json to use consistent "检查点" (checkpoint) terminology

However, the test expectation issues remain unresolved:

Issues to Fix

  • Test at line 307 expects translation key "errors.checkpoint_diff_to_current" but should expect the translated string "Changes to current workspace"
  • Test at line 332 expects translation key "errors.checkpoint_diff_with_next" but should expect the translated string "Changes compared with next checkpoint"
  • Test at line 367 expects translation key "errors.checkpoint_no_changes" but should expect the translated string "No changes found."

Follow Along on Roo Code Cloud

@daniel-lxs daniel-lxs mentioned this pull request Oct 23, 2025
6 tasks
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. Found 1 issue that should be addressed before approval. See inline comments for details.

@daniel-lxs daniel-lxs force-pushed the feat/improve-checkpoint-menu-translations branch from 094c272 to 91689d4 Compare October 23, 2025 21:57
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 23, 2025
- Add missing 'checkpoint.menu.more' translation key for accessibility
- Add translation keys for checkpoint diff messages (no_first, no_previous, no_changes, diff_with_next, diff_since_first, diff_to_current)
- Fix English wording: 'compared with' instead of 'compare with'
- Fix naming inconsistency: rename setRestoreIsConfirming to setRestoreConfirming
- Update tests to expect translation keys instead of hardcoded strings
- All translations added to 18 supported languages
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Oct 23, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 23, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. There are still unresolved test issues that need to be addressed before approval.

@mrubens mrubens merged commit 485b551 into main Oct 24, 2025
12 checks passed
@mrubens mrubens deleted the feat/improve-checkpoint-menu-translations branch October 24, 2025 14:03
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 24, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 24, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants