Skip to content

Conversation

@inderdeep-singh-zomato
Copy link

@inderdeep-singh-zomato inderdeep-singh-zomato commented Nov 4, 2025

This PR was automatically generated by Stitch Remote SWE.

🎯 Task Details
  • Add support for setting accent color in the extension to allow for theming customisation.

Author: [email protected]


Important

Add support for custom accent color theming by updating global settings, message handling, and UI components.

  • Behavior:
    • Add accentColor to globalSettingsSchema in global-settings.ts for theming customization.
    • Handle setAccentColor message in webviewMessageHandler.ts to update global state and UI.
  • UI Components:
    • Update App.tsx to apply accentColor to CSS properties.
    • Add accent color input in UISettings.tsx with validation and telemetry tracking.
    • Update SettingsView.tsx to include accentColor in UI settings.
  • State Management:
    • Add accentColor state and setter in ExtensionStateContext.tsx to manage accent color changes.

This description was created by Ellipsis for 547b545. You can customize this summary. It will automatically update as commits are pushed.

Enable users to set an accent color in the extension settings for improved theming customization. This change applies the accent color throughout the UI using CSS variables.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 4, 2025
@roomote
Copy link

roomote bot commented Nov 4, 2025

See this task on Roo Code Cloud

Review completed. Found 1 issue that needs to be addressed:

  • Fix accent color persistence in SettingsView - setting is not saved when clicking Save button

Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request.

@dosubot dosubot bot added the enhancement New feature or request label Nov 4, 2025
{activeTab === "ui" && (
<UISettings
reasoningBlockCollapsed={reasoningBlockCollapsed ?? true}
accentColor={extensionState.accentColor}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accent color setting is not persisted correctly. Using extensionState.accentColor here bypasses the cached state system used by SettingsView, which means changes won't be included in the Save button's dirty state tracking and won't be persisted when clicking Save.

This should use accentColor from cachedState (destructured around line 201), and the handleSubmit function needs to send it via vscode.postMessage({ type: 'setAccentColor', text: accentColor }) to persist changes on Save.

Fix it with Roo Code or mention @roomote and request a fix.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 4, 2025
@daniel-lxs
Copy link
Member

Thanks for the contribution! Unfortunately this feature is not currently planned, as it falls outside the current scope of our roadmap. We’ll reconsider if there’s broader demand or a related use case in future iterations.

@daniel-lxs daniel-lxs closed this Nov 5, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 5, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants