Add missing transformer tap to the networkx graph (#427)

Author: alihamdan

doc/Changelog.md

@@ -21,6 +21,8 @@ og:description: See what's new in the latest release of Roseau Load Flow !
 
 ## Unreleased
 
+- {gh-pr}`427` Add missing transformer tap to the edge data in the graph generated by `ElectricalNetwork.to_graph`.
+
 - {gh-pr}`426` Add `rlf.plotting.plot_results_interactive_map` for plotting a network with load flow results on an
   interactive map. Buses are colored according to their voltage levels and lines are colored according to their loading
   levels.

roseau/load_flow/network.py

@@ -416,6 +416,7 @@ def to_graph(self, *, respect_switches: bool = True) -> "MultiGraph":
                 parameters_id=transformer.parameters.id,
                 max_loading=transformer._max_loading,
                 sn=transformer.parameters._sn,
+                tap=transformer._tap,
                 geom=geom_mapping(transformer.geometry),
             )
         for switch in self.switches.values():

roseau/load_flow/tests/test_electrical_network.py

@@ -2093,6 +2093,7 @@ def test_to_graph(all_element_network: ElectricalNetwork):
             "parameters_id": transformer.parameters.id,
             "max_loading": max_loading,
             "sn": transformer.sn.magnitude,
+            "tap": transformer.tap,
             "geom": transformer.geometry.__geo_interface__ if transformer.geometry is not None else None,
         }
 

roseau/load_flow_single/network.py

@@ -284,6 +284,7 @@ def to_graph(self, *, respect_switches: bool = True) -> "MultiGraph":
                 id=line.id,
                 type="line",
                 parameters_id=line.parameters.id,
+                length=line._length,
                 max_loading=line._max_loading,
                 ampacity=line.parameters._ampacity,
                 geom=geom_mapping(line.geometry),
@@ -297,6 +298,7 @@ def to_graph(self, *, respect_switches: bool = True) -> "MultiGraph":
                 parameters_id=transformer.parameters.id,
                 max_loading=transformer._max_loading,
                 sn=transformer.parameters._sn,
+                tap=transformer._tap,
                 geom=geom_mapping(transformer.geometry),
             )
         for switch in self.switches.values():

roseau/load_flow_single/tests/test_electrical_network.py

@@ -1140,6 +1140,7 @@ def test_to_graph(small_network: ElectricalNetwork):
             "parameters_id": line.parameters.id,
             "max_loading": line.max_loading.m,
             "ampacity": ampacity,
+            "length": line.length.m,
             "geom": line.geometry.__geo_interface__ if line.geometry is not None else None,
         }
 
@@ -1151,6 +1152,7 @@ def test_to_graph(small_network: ElectricalNetwork):
             "parameters_id": transformer.parameters.id,
             "max_loading": transformer.max_loading.m,
             "sn": transformer.sn.m,
+            "tap": transformer.tap,
             "geom": transformer.geometry.__geo_interface__ if transformer.geometry is not None else None,
         }