Skip to content

Missing spaces after comma in template argument lists #332

@lczech

Description

@lczech

Hi @lyskov,

I've noticed that template argument lists are produced without spaces after the commas separating individual arguments, see here and here. This is inconsistent with all other uses of comma-separated lists in Binder, and means that addressing function or class template with more than one template argument is not intuitive.

I've fixed this here, and want to open a PR (once the formatting is done to avoid merge conflicts). However, I've noticed that this small change has led to some rearrangements in the generated bindings in some test cases. I don't know if that is expected due to some reordering based on generated code length, but would like you to have a look if this is all in order.

Cheers
Lucas

Edit: For function members of class templates, the template arguments of the class already contained spaces between the template arguments. The missing spaces are only in free function templates and class templates themselves, making this a vexing inconsistency when specifying them in config directives.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions