FIX (backups): Fix deleting backups on storage change from joined storages

Author: RostislavDugin

backend/internal/features/backups/backups/model.go

@@ -1,7 +1,6 @@
 package backups
 
 import (
-	"log/slog"
 	"postgresus-backend/internal/features/databases"
 	"postgresus-backend/internal/features/storages"
 	"time"
@@ -27,16 +26,3 @@ type Backup struct {
 
 	CreatedAt time.Time `json:"createdAt" gorm:"column:created_at"`
 }
-
-func (b *Backup) DeleteBackupFromStorage(logger *slog.Logger) {
-	if b.Status != BackupStatusCompleted {
-		return
-	}
-
-	err := b.Storage.DeleteFile(b.ID)
-	if err != nil {
-		logger.Error("Failed to delete backup from storage", "error", err)
-		// we ignore the error, because the access to the storage
-		// may be lost, file already deleted, etc.
-	}
-}

backend/internal/features/backups/backups/service.go

@@ -347,7 +347,15 @@ func (s *BackupService) deleteBackup(backup *Backup) error {
 		}
 	}
 
-	backup.DeleteBackupFromStorage(s.logger)
+	storage, err := s.storageService.GetStorageByID(backup.StorageID)
+	if err != nil {
+		return err
+	}
+
+	err = storage.DeleteFile(backup.ID)
+	if err != nil {
+		return err
+	}
 
 	return s.backupRepository.DeleteByID(backup.ID)
 }