Skip to content

Commit e6ce32b

Browse files
FIX (tests): Return ensuring directories for LocalStorage to not fail tests
1 parent d4ec46e commit e6ce32b

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

backend/internal/features/storages/model_test.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
local_storage "postgresus-backend/internal/features/storages/models/local"
1313
nas_storage "postgresus-backend/internal/features/storages/models/nas"
1414
s3_storage "postgresus-backend/internal/features/storages/models/s3"
15-
files_utils "postgresus-backend/internal/util/files"
1615
"postgresus-backend/internal/util/logger"
1716
"strconv"
1817
"testing"
@@ -38,13 +37,6 @@ func Test_Storage_BasicOperations(t *testing.T) {
3837

3938
validateEnvVariables(t)
4039

41-
// create directories that used for backups and restore
42-
err := files_utils.EnsureDirectories([]string{
43-
config.GetEnv().TempFolder,
44-
config.GetEnv().DataFolder,
45-
})
46-
require.NoError(t, err, "Failed to ensure directories")
47-
4840
// Setup S3 connection to docker-compose MinIO
4941
s3Container, err := setupS3Container(ctx)
5042
require.NoError(t, err, "Failed to setup S3 container")

backend/internal/features/storages/models/local/model.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"os"
88
"path/filepath"
99
"postgresus-backend/internal/config"
10+
files_utils "postgresus-backend/internal/util/files"
1011

1112
"github.com/google/uuid"
1213
)
@@ -129,11 +130,18 @@ func (l *LocalStorage) DeleteFile(fileID uuid.UUID) error {
129130
}
130131

131132
func (l *LocalStorage) Validate() error {
132-
// nothing to validate
133133
return nil
134134
}
135135

136136
func (l *LocalStorage) TestConnection() error {
137+
err := files_utils.EnsureDirectories([]string{
138+
config.GetEnv().TempFolder,
139+
config.GetEnv().DataFolder,
140+
})
141+
if err != nil {
142+
return fmt.Errorf("failed to ensure directories: %w", err)
143+
}
144+
137145
testFile := filepath.Join(config.GetEnv().TempFolder, "test_connection")
138146
f, err := os.Create(testFile)
139147
if err != nil {

0 commit comments

Comments
 (0)