Fix trying to cache two times

Rothes · Rothes · commit 2bc85efca308 · 2024-10-11T18:12:10.000+08:00
diff --git a/bukkit/src/main/java/io/github/rothes/protocolstringreplacer/packetlistener/server/BaseServerPacketListener.java b/bukkit/src/main/java/io/github/rothes/protocolstringreplacer/packetlistener/server/BaseServerPacketListener.java
@@ -300,7 +300,7 @@ protected static ItemStack replaceItemStack(@Nonnull PacketEvent packetEvent, @N
             ReplacerManager replacerManager = ProtocolStringReplacer.getInstance().getReplacerManager();
             ItemStackContainer container = new ItemStackContainer(itemStack);
 
-            if (!container.isFromCache() && cacheItemStack(container, nbt, lore, entries)) {
+            if (!container.isFromCache()) {
                 cacheItemStack(container, nbt, lore, entries);
             }
             if (container.getMetaCache().isBlocked()) {

Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,7 @@ protected static ItemStack replaceItemStack(@Nonnull PacketEvent packetEvent, @N`
`300`	`300`	`ReplacerManager replacerManager = ProtocolStringReplacer.getInstance().getReplacerManager();`
`301`	`301`	`ItemStackContainer container = new ItemStackContainer(itemStack);`
`302`	`302`
`303`		`- if (!container.isFromCache() && cacheItemStack(container, nbt, lore, entries)) {`
	`303`	`+ if (!container.isFromCache()) {`
`304`	`304`	`cacheItemStack(container, nbt, lore, entries);`
`305`	`305`	`}`
`306`	`306`	`if (container.getMetaCache().isBlocked()) {`