Code improvements

Author: Rothes

src/main/java/me/rothes/protocolstringreplacer/Updater.java

@@ -27,7 +27,7 @@
 
 public class Updater implements Listener {
 
-    private static final String VERSION_CHANCEL = "Stable";
+    private static final String VERSION_CHANNEL = "Stable";
     private static final int VERSION_NUMBER = 105;
     private final HashMap<String, Integer> msgTimesMap = new HashMap<>();
     private final List<String> messages = new ArrayList<>();
@@ -123,15 +123,15 @@ private void checkJson(String json) {
         JsonObject channels = root.getAsJsonObject("Version_Channels");
 
         messages.clear();
-        if (channels.has(VERSION_CHANCEL)) {
-            JsonObject channel = channels.getAsJsonObject(VERSION_CHANCEL);
+        if (channels.has(VERSION_CHANNEL)) {
+            JsonObject channel = channels.getAsJsonObject(VERSION_CHANNEL);
             if (channel.has("Message")
                     && channel.getAsJsonPrimitive("Latest_Version_Number").getAsInt() > VERSION_NUMBER) {
                 sendJsonMessage(channel, "updater");
             }
         } else {
-            ProtocolStringReplacer.warn(PsrLocalization.getLocaledMessage("Console-Sender.Messages.Updater.Invalid-Channel", VERSION_CHANCEL));
-            messages.add(PsrLocalization.getLocaledMessage("Console-Sender.Messages.Updater.Invalid-Channel", VERSION_CHANCEL));
+            ProtocolStringReplacer.warn(PsrLocalization.getLocaledMessage("Console-Sender.Messages.Updater.Invalid-Channel", VERSION_CHANNEL));
+            messages.add(PsrLocalization.getLocaledMessage("Console-Sender.Messages.Updater.Invalid-Channel", VERSION_CHANNEL));
             return;
         }
 

src/main/java/me/rothes/protocolstringreplacer/api/user/PsrUserManager.java

@@ -11,8 +11,8 @@
 
 public class PsrUserManager {
 
-    private HashMap<UUID, PsrUser> users = new HashMap<>();
-    private PsrUser console = new PsrUser(Bukkit.getConsoleSender());
+    private final HashMap<UUID, PsrUser> users = new HashMap<>();
+    private final PsrUser console = new PsrUser(Bukkit.getConsoleSender());
 
     public PsrUser getUser(@NotNull UUID uuid) {
         return users.getOrDefault(uuid, loadUser(uuid));

src/main/java/me/rothes/protocolstringreplacer/commands/CommandHandler.java

@@ -24,7 +24,7 @@
 
 public class CommandHandler implements TabCompleter, CommandExecutor {
 
-    private LinkedList<SubCommand> subCommands = new LinkedList<>();
+    private final LinkedList<SubCommand> subCommands = new LinkedList<>();
 
     public void initialize() {
         ProtocolStringReplacer.getInstance().getCommand("ProtocolStringReplacer").setExecutor(this);

src/main/java/me/rothes/protocolstringreplacer/commands/SubCommand.java

@@ -7,9 +7,9 @@
 
 public abstract class SubCommand {
 
-    private String name;
-    private String permission;
-    private String description;
+    private final String name;
+    private final String permission;
+    private final String description;
 
     public SubCommand(@Nonnull String name, @Nonnull String permission, @Nonnull String description) {
         this.name = name;

src/main/java/me/rothes/protocolstringreplacer/commands/subcommands/Edit.java

@@ -15,7 +15,7 @@
 
 public class Edit extends SubCommand {
 
-    private LinkedList<SubCommand> childCommands = new LinkedList<>();
+    private final LinkedList<SubCommand> childCommands = new LinkedList<>();
 
     public Edit() {
         super("edit", "protocolstringreplacer.command.edit",

src/main/java/me/rothes/protocolstringreplacer/console/PsrFilter.java

@@ -16,7 +16,7 @@
 
 public class PsrFilter implements Filter {
 
-    private ProtocolStringReplacer plugin;
+    private final ProtocolStringReplacer plugin;
     private boolean started = false;
 
     public PsrFilter(@NotNull ProtocolStringReplacer plugin) {

src/main/java/me/rothes/protocolstringreplacer/console/PsrWrappedLineReader.java

@@ -23,7 +23,7 @@
 
 public class PsrWrappedLineReader implements LineReader{
 
-    private LineReader reader;
+    private final LineReader reader;
 
     public PsrWrappedLineReader(LineReader reader) {
         this.reader = reader;

src/main/java/me/rothes/protocolstringreplacer/packetlisteners/server/AbstractServerComponentsPacketListener.java

@@ -19,7 +19,7 @@ protected AbstractServerComponentsPacketListener(PacketType packetType, ListenTy
         super(packetType, listenType);
     }
 
-    protected BaseComponent[] getSpigotComponent(StructureModifier<Object> modifier) {
+    protected static BaseComponent[] getSpigotComponent(StructureModifier<Object> modifier) {
         if (!ProtocolStringReplacer.getInstance().isSpigot()) {
             return null;
         }
@@ -48,7 +48,7 @@ protected String processSpigotComponent(StructureModifier<Object> modifier, Pack
         return result == null ? BLOCKED_JSON : result;
     }
 
-    protected Component getPaperComponent(StructureModifier<Object> modifier) {
+    protected static Component getPaperComponent(StructureModifier<Object> modifier) {
         if (!ProtocolStringReplacer.getInstance().hasPaperComponent()) {
             return null;
         }

src/main/java/me/rothes/protocolstringreplacer/utils/ArgUtils.java

@@ -9,7 +9,7 @@
 
 public class ArgUtils {
 
-    private static Pattern lastQuotes = Pattern.compile("\"+$");
+    private static final Pattern lastQuotes = Pattern.compile("\"+$");
 
     @Nonnull
     public static String formatWithQuotes(@Nonnull String string) {