Fix blocking non-cache itemstack is not cancelling packet

Rothes · Rothes · commit a5085f0e426f · 2024-10-05T11:54:10.000+08:00
diff --git a/bukkit/src/main/java/io/github/rothes/protocolstringreplacer/packetlistener/server/BaseServerPacketListener.java b/bukkit/src/main/java/io/github/rothes/protocolstringreplacer/packetlistener/server/BaseServerPacketListener.java
@@ -302,8 +302,7 @@ protected static ItemStack replaceItemStack(@Nonnull PacketEvent packetEvent, @N
             ItemStackContainer container = new ItemStackContainer(itemStack);
 
             if (!container.isFromCache() && cacheItemStack(container, nbt, lore, entries)) {
-                // Blocked
-                return null;
+                cacheItemStack(container, nbt, lore, entries);
             }
             if (container.getMetaCache().isBlocked()) {
                 packetEvent.setCancelled(true);

Original file line number	Diff line number	Diff line change
`@@ -302,8 +302,7 @@ protected static ItemStack replaceItemStack(@Nonnull PacketEvent packetEvent, @N`
`302`	`302`	`ItemStackContainer container = new ItemStackContainer(itemStack);`
`303`	`303`
`304`	`304`	`if (!container.isFromCache() && cacheItemStack(container, nbt, lore, entries)) {`
`305`		`- // Blocked`
`306`		`- return null;`
	`305`	`+ cacheItemStack(container, nbt, lore, entries);`
`307`	`306`	`}`
`308`	`307`	`if (container.getMetaCache().isBlocked()) {`
`309`	`308`	`packetEvent.setCancelled(true);`