fix: wait for Chrome to exit

Author: goooseman

lib/index.js

@@ -28,9 +28,9 @@ module.exports = class ReactBenchmark extends EventEmitter {
     })
   }
 
-  _shutdown() {
-    this.chrome.stop()
-    this.server.stop()
+  async _shutdown() {
+    await this.chrome.stop()
+    await this.server.stop()
     this.running = false
   }
 
@@ -61,19 +61,17 @@ module.exports = class ReactBenchmark extends EventEmitter {
     const port = await this.server.start(outputPath)
 
     return new Promise((resolve, reject) => {
-      this.chrome.once('complete', (benchmark) => {
+      this.chrome.once('complete', async (benchmark) => {
         if (!devtools) {
-          this._shutdown()
+          await this._shutdown()
         }
-
         resolve(benchmark)
       })
 
-      this.chrome.once('error', (err) => {
+      this.chrome.once('error', async (err) => {
         if (!devtools) {
-          this._shutdown()
+          await this._shutdown()
         }
-
         reject(err)
       })
 

test/cli.js

@@ -2,8 +2,6 @@ const path = require('path')
 const test = require('ava')
 const execa = require('execa')
 
-const sleep = (ms) => new Promise((res) => setTimeout(res, ms))
-
 test('runs benchmark', async (t) => {
   const binPath = path.resolve(__dirname, '../lib/cli.js')
   const fixturePath = path.resolve(__dirname, 'fixtures/benchmark.js')
@@ -23,7 +21,6 @@ test('throttles CPU', async (t) => {
   const fixturePath = path.resolve(__dirname, 'fixtures/benchmark.js')
 
   const woutT = (await execa(binPath, [fixturePath])).stdout
-  await sleep(100) // sometimes port is still in use
   const withT = (await execa(binPath, [fixturePath, '--cpuThrottle=4'])).stdout
 
   // difference should be more then 2 times