Fix post-refactor regressions and bump native vendor to Zireael #103 (#223)

* refactor(renderer): replace WeakMap theme propagation with stack

* chore(native): sync Zireael v1.3.8-alpha.8

* core(drawlist): add buildInto for v2 and v3 builders

* ci: optimize PR pipeline — concurrency, fast gate, reduced matrix

- Add concurrency group to ci.yml and codeql.yml to cancel in-progress
  runs on re-push (biggest win for runner contention)
- Extract lint/typecheck/codegen/portability/unicode into a dedicated
  `checks` job that gates the matrix — lint failures caught in ~2 min
  instead of after the full 15-min pipeline
- Dynamic matrix: 5 runners on PRs (Linux × Node 18/20/22, macOS × 22,
  Windows × 22), full 3×3 on push to main
- Remove redundant lint/typecheck/codegen/biome-install steps from each
  matrix cell and the bun job
- Remove duplicate docs job (already handled by docs.yml)

Net effect on PRs: 13 jobs → 9, ~44% fewer runners, fast-fail on
static checks, stale runs cancelled automatically.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Revert "ci: optimize PR pipeline — concurrency, fast gate, reduced matrix"

This reverts commit 183532e.

* EPIC 6: packed style pipeline + Zireael vendor bump

* fix(core): restore canvas overlay hex parsing

* fix(ci): satisfy guardrails, lint, and typecheck

* fix(review): address outstanding PR threads and CI regressions

* feat: land blit-rect pipeline and regression audit tooling

* Fix refactor regressions and sync native vendor to Zireael PR

* Bump vendored Zireael to include review-thread fixes

* vendor zireael: bump to c0849ae after main merge

* Address PR #223 unresolved review feedback

* Fix drawlist text perf counters and CI lockfile sync

* Fix regression dashboard lint violations

* Fix CI lint failures and apply review nitpicks

* Apply biome formatting fixes for CI lint

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: RtlZeroMemory

.github/workflows/ci.yml

@@ -58,6 +58,9 @@ jobs:
       - name: Check core portability
         run: npm run check:core-portability
 
+      - name: Check native vendor integrity
+        run: npm run check:native-vendor
+
       - name: Check Unicode pins (submodule sync)
         run: npm run check:unicode
 

AGENTS.md

@@ -55,7 +55,7 @@ Key pipeline files:
 - `packages/core/src/runtime/router/wheel.ts` — mouse wheel routing for scroll targets
 - `packages/core/src/renderer/renderToDrawlist/renderTree.ts` — stack-based DFS renderer
 - `packages/core/src/layout/dropdownGeometry.ts` — shared dropdown overlay geometry
-- `packages/core/src/drawlist/builder_v1.ts` — ZRDL binary drawlist builder
+- `packages/core/src/drawlist/builder.ts` — ZRDL binary drawlist builder (unified)
 
 ## Layout Engine Baseline (Current)
 
@@ -129,7 +129,7 @@ When core widget APIs change, JSX must be updated in the same change set.
 
 ### Drawlist writer codegen guardrail (MUST for ZRDL command changes)
 
-The v3/v4/v5 command writer implementation is code-generated. Never hand-edit
+The command writer implementation is code-generated. Never hand-edit
 `packages/core/src/drawlist/writers.gen.ts`.
 
 When changing drawlist command layout/opcodes/field widths/offsets:

CLAUDE.md

@@ -50,9 +50,9 @@ packages/core/src/
     renderToDrawlist/
       renderTree.ts           # Stack-based DFS renderer
   drawlist/
-    builder_v1.ts             # ZRDL binary drawlist builder (v1)
-    builder_v2.ts             # Drawlist builder v2 (cursor protocol)
-    builder_v3.ts             # Drawlist builder v3
+    builder.ts                # ZRDL binary drawlist builder (single unified version)
+    builderBase.ts            # Abstract base class for drawlist builder
+    writers.gen.ts            # Generated drawlist command writers (codegen)
   keybindings/
     manager.ts                # Modal keybinding system
     parser.ts                 # Key sequence parsing

docs/backend/native.md

@@ -163,7 +163,7 @@ source.
 - **Node.js 18+** with npm
 - **Rust toolchain** (for napi-rs compilation)
 - **C toolchain** (gcc, clang, or MSVC) for the Zireael engine
-- **Git submodules** initialized (`vendor/zireael` must be present)
+- **Git metadata available** (for vendor pin checks; full submodule checkout is needed when refreshing vendored engine sources)
 
 ### Build Command
 

docs/dev/build.md

@@ -35,9 +35,10 @@ cd Rezi
 git submodule update --init --recursive
 ```
 
-The `vendor/zireael` submodule contains the Zireael C engine source. It must be
-present for native addon builds, but is not required for TypeScript-only
-development.
+The `vendor/zireael` submodule tracks the upstream Zireael source and commit
+pin metadata. Native addon builds compile from the package-local snapshot at
+`packages/native/vendor/zireael`; submodule checkout is required when syncing
+or auditing vendored engine updates, but not for TypeScript-only development.
 
 Install all dependencies:
 

docs/dev/repo-layout.md

@@ -144,6 +144,7 @@ Build, test, and CI automation scripts.
 | `docs.sh`                          | Documentation build/serve with automatic venv management. |
 | `guardrails.sh`                    | Repository hygiene checks for forbidden patterns (legacy scope/name, unresolved task markers, and synthetic-content markers). |
 | `check-core-portability.mjs`      | Scans `@rezi-ui/core` for prohibited Node.js imports. |
+| `check-native-vendor-integrity.mjs` | Verifies native vendor source wiring and `VENDOR_COMMIT.txt` pin consistency with `vendor/zireael`. |
 | `check-unicode-sync.mjs`          | Verifies Unicode table versions are consistent. |
 | `check-create-rezi-templates.mjs` | Validates scaffolding templates are up to date. |
 | `verify-native-pack.mjs`          | Checks native package contents before npm publish. |
@@ -152,9 +153,11 @@ Build, test, and CI automation scripts.
 ## vendor/zireael
 
 The Zireael C rendering engine, pinned as a git submodule. This is the upstream
-source used by `@rezi-ui/native` for compilation. The native package keeps its
-own vendored snapshot at `packages/native/vendor/zireael` as the compile-time
-source.
+reference tree. `@rezi-ui/native` compiles from the package-local snapshot at
+`packages/native/vendor/zireael` (see `packages/native/build.rs`).
+
+`packages/native/vendor/VENDOR_COMMIT.txt` must match the repo gitlink pointer
+for `vendor/zireael`; CI enforces this via `npm run check:native-vendor`.
 
 Initialize with:
 

docs/protocol/versioning.md

@@ -24,6 +24,8 @@ Pinned drawlist version:
 
 Rezi currently emits ZRDL v1, and the engine accepts v1/v2.
 ZRDL v2 adds opcode `14` (`BLIT_RECT`).
+Style link reference fields (`linkUriRef`, `linkIdRef`) are stable across v1/v2:
+`0` means unset and positive values are 1-based string resource IDs.
 
 ## Event Batch (ZREV)
 

docs/protocol/zrdl.md

@@ -57,6 +57,23 @@ Commands are 4-byte aligned.
 - `FREE_*` invalidates that ID.
 - Draw commands referencing unknown IDs fail.
 
+## Style Payload Link References
+
+Text-bearing commands carry style fields that include hyperlink references:
+
+- `linkUriRef` (`u32`)
+- `linkIdRef` (`u32`)
+
+These fields use the same ID space as `DEF_STRING`/`FREE_STRING` and are
+**1-based**:
+
+- `0` means "no active link" (sentinel unset)
+- `N > 0` maps to string resource ID `N`
+
+Rezi encodes link references as `(internedIndex + 1)`, and Zireael resolves
+them as direct string IDs. This is part of the v1/v2 wire contract and does
+not introduce a new drawlist version.
+
 ## Codegen
 
 Command layouts are defined in `scripts/drawlist-spec.ts`.

examples/regression-dashboard/README.md

@@ -0,0 +1,47 @@
+# Regression Dashboard Example
+
+Dashboard-based regression app for manually validating rendering behavior after core refactors.
+
+## Run (from repo root)
+
+```bash
+npm --prefix examples/regression-dashboard run start
+```
+
+Interactive mode requires a real TTY terminal.
+
+## Run with HSR
+
+```bash
+npm --prefix examples/regression-dashboard run dev
+```
+
+## Headless Preview (non-TTY safe)
+
+```bash
+npm --prefix examples/regression-dashboard run preview
+```
+
+## Build / Typecheck / Test
+
+```bash
+npm --prefix examples/regression-dashboard run build
+npm --prefix examples/regression-dashboard run typecheck
+npm --prefix examples/regression-dashboard run test
+```
+
+## What to check
+
+- Scroll service lanes with wheel/keys and verify no visual tearing.
+- Change filters/theme while telemetry ticks are active.
+- Open/close help modal repeatedly.
+- Verify focus/selection remains stable during rapid updates.
+
+## Controls
+
+- `up` / `down` or `j` / `k`: Move selection
+- `f`: Cycle fleet filter
+- `t`: Cycle theme
+- `p` or `space`: Pause/resume telemetry stream
+- `h` or `?`: Toggle help modal
+- `q` or `ctrl+c`: Quit