fix: leaf reuse correctness + lint

Author: RezoR0xFF

packages/bench/src/blessed-backend.ts

@@ -57,8 +57,7 @@ export function createBlessedContext(cols: number, rows: number): BlessedContext
       _encoding: BufferEncoding,
       callback: (error?: Error | null) => void,
     ) {
-      totalBytes +=
-        typeof chunk === "string" ? Buffer.byteLength(chunk) : chunk.byteLength;
+      totalBytes += typeof chunk === "string" ? Buffer.byteLength(chunk) : chunk.byteLength;
       callback();
     },
     highWaterMark: 1024 * 1024,
@@ -69,10 +68,12 @@ export function createBlessedContext(cols: number, rows: number): BlessedContext
   Object.defineProperty(measureStream, "rows", { value: rows, writable: true });
   Object.defineProperty(measureStream, "isTTY", { value: true });
 
-  const nullInput = new Readable({ read() {} });
+  const nullInput = new Readable({ read() {} }) as Readable & {
+    setRawMode?: (mode: boolean) => unknown;
+  };
   Object.defineProperty(nullInput, "isTTY", { value: false });
   // blessed calls setRawMode on stdin
-  (nullInput as unknown as Record<string, unknown>)["setRawMode"] = () => nullInput;
+  nullInput.setRawMode = () => nullInput;
 
   const screen = blessed.screen({
     output: measureStream,
@@ -91,7 +92,7 @@ export function createBlessedContext(cols: number, rows: number): BlessedContext
     screen,
     blessed,
     flush() {
-      if (screen.program && screen.program.flush) {
+      if (screen.program?.flush) {
         screen.program.flush();
       }
     },

packages/bench/src/profile-construction.ts

@@ -3,7 +3,7 @@
  * Usage: REZI_PERF=1 REZI_PERF_DETAIL=1 npx tsx src/profile-construction.ts
  */
 
-import { createApp, perfSnapshot, perfReset } from "@rezi-ui/core";
+import { createApp, perfReset, perfSnapshot } from "@rezi-ui/core";
 import { BenchBackend } from "./backends.js";
 import { buildReziTree } from "./scenarios/treeBuilders.js";
 
@@ -53,9 +53,9 @@ async function main() {
     if (!stats || stats.count === 0) continue;
     console.log(
       `  ${phase.padEnd(22)} avg=${(stats.avg * 1000).toFixed(0).padStart(6)}µs  ` +
-      `p95=${(stats.p95 * 1000).toFixed(0).padStart(6)}µs  ` +
-      `p99=${(stats.p99 * 1000).toFixed(0).padStart(6)}µs  ` +
-      `count=${String(stats.count).padStart(5)}`
+        `p95=${(stats.p95 * 1000).toFixed(0).padStart(6)}µs  ` +
+        `p99=${(stats.p99 * 1000).toFixed(0).padStart(6)}µs  ` +
+        `count=${String(stats.count).padStart(5)}`,
     );
   }
 

packages/bench/src/profile-phases.ts

@@ -3,7 +3,7 @@
  * Usage: REZI_PERF=1 REZI_PERF_DETAIL=1 npx tsx src/profile-phases.ts
  */
 
-import { createApp, perfSnapshot, perfReset, ui, type VNode } from "@rezi-ui/core";
+import { type VNode, createApp, perfReset, perfSnapshot, ui } from "@rezi-ui/core";
 import { BenchBackend } from "./backends.js";
 
 const LIST_SIZE = 500;
@@ -80,9 +80,9 @@ async function main() {
     if (!stats || stats.count === 0) continue;
     console.log(
       `  ${phase.padEnd(22)} avg=${(stats.avg * 1000).toFixed(0).padStart(6)}µs  ` +
-      `p95=${(stats.p95 * 1000).toFixed(0).padStart(6)}µs  ` +
-      `p99=${(stats.p99 * 1000).toFixed(0).padStart(6)}µs  ` +
-      `count=${String(stats.count).padStart(5)}`
+        `p95=${(stats.p95 * 1000).toFixed(0).padStart(6)}µs  ` +
+        `p99=${(stats.p99 * 1000).toFixed(0).padStart(6)}µs  ` +
+        `count=${String(stats.count).padStart(5)}`,
     );
   }
 

packages/bench/src/ratatui-runner.ts

@@ -6,7 +6,7 @@
  * back into BenchMetrics.
  */
 
-import { execSync, execFileSync } from "node:child_process";
+import { execFileSync, execSync } from "node:child_process";
 import { existsSync } from "node:fs";
 import { resolve } from "node:path";
 import { computeStats, takeMemory } from "./measure.js";
@@ -87,7 +87,7 @@ interface RatatuiOutput {
 export function runRatatui(
   scenario: string,
   config: ScenarioConfig,
-  params: Record<string, number | string> = {},
+  params: Readonly<{ items?: number | string }> = {},
 ): BenchMetrics {
   ensureBuilt();
 
@@ -100,8 +100,8 @@ export function runRatatui(
     String(config.iterations),
   ];
 
-  if (params["items"] !== undefined) {
-    args.push("--items", String(params["items"]));
+  if (params.items !== undefined) {
+    args.push("--items", String(params.items));
   }
 
   const stdout = execFileSync(BINARY, args, {

packages/bench/src/report.ts

@@ -123,7 +123,14 @@ export function toMarkdown(results: readonly BenchResult[]): string {
     );
     lines.push("|---|---:|---:|---:|---:|---:|---:|---:|---:|");
 
-    const order: Framework[] = ["rezi-native", "ink-compat", "ink", "terminal-kit", "blessed", "ratatui"];
+    const order: Framework[] = [
+      "rezi-native",
+      "ink-compat",
+      "ink",
+      "terminal-kit",
+      "blessed",
+      "ratatui",
+    ];
     const sorted = [...items].sort(
       (a, b) => order.indexOf(a.framework) - order.indexOf(b.framework),
     );
@@ -139,7 +146,9 @@ export function toMarkdown(results: readonly BenchResult[]): string {
 
   // Summary: relative performance (ratio = other / rezi; >1 means rezi is faster)
   lines.push("## Relative Performance (vs Rezi native)\n");
-  lines.push("> \"Xx slower\" = Rezi native is X times faster. \"Xx faster\" = other framework is faster.\n");
+  lines.push(
+    '> "Xx slower" = Rezi native is X times faster. "Xx faster" = other framework is faster.\n',
+  );
 
   // Determine which frameworks have results
   const allFws: Framework[] = ["ink", "ink-compat", "terminal-kit", "blessed", "ratatui"];

packages/bench/src/scenarios/construction.ts

@@ -13,7 +13,12 @@
 import { BenchBackend, MeasuringStream, NullReadable } from "../backends.js";
 import { benchAsync, benchSync, tryGc } from "../measure.js";
 import type { BenchMetrics, Framework, Scenario, ScenarioConfig } from "../types.js";
-import { buildBlessedTree, buildReactTree, buildReziTree, buildTermkitTree } from "./treeBuilders.js";
+import {
+  buildBlessedTree,
+  buildReactTree,
+  buildReziTree,
+  buildTermkitTree,
+} from "./treeBuilders.js";
 
 async function runRezi(config: ScenarioConfig, n: number): Promise<BenchMetrics> {
   const { createApp } = await import("@rezi-ui/core");
@@ -225,10 +230,7 @@ async function runBlessed(config: ScenarioConfig, n: number): Promise<BenchMetri
   return metrics;
 }
 
-async function runRatatui(
-  config: ScenarioConfig,
-  n: number,
-): Promise<BenchMetrics> {
+async function runRatatui(config: ScenarioConfig, n: number): Promise<BenchMetrics> {
   const { runRatatui: exec } = await import("../ratatui-runner.js");
   return exec("construction", config, { items: n });
 }

packages/bench/src/scenarios/content-update.ts

@@ -68,11 +68,7 @@ function reactListTree(
         { key: String(i), flexDirection: "row", gap: 1 },
         h(C.Text as string, { bold: isSelected }, isSelected ? ">" : " "),
         h(C.Text as string, { dimColor: !isSelected }, `${String(i).padStart(3, " ")}.`),
-        h(
-          C.Text as string,
-          { bold: isSelected, inverse: isSelected },
-          `entry-${i}.log`,
-        ),
+        h(C.Text as string, { bold: isSelected, inverse: isSelected }, `entry-${i}.log`),
         h(C.Text as string, { dimColor: true }, `${(i * 1024 + 512).toLocaleString()} B`),
       ),
     );
@@ -106,14 +102,8 @@ function termkitListTree(
     const y = 2 + i;
     const isSelected = i === selected;
     buffer.put({ x: 0, y, attr: { bold: isSelected } }, isSelected ? ">" : " ");
-    buffer.put(
-      { x: 2, y, attr: { dim: !isSelected } },
-      `${String(i).padStart(3, " ")}.`,
-    );
-    buffer.put(
-      { x: 8, y, attr: { bold: isSelected, inverse: isSelected } },
-      `entry-${i}.log`,
-    );
+    buffer.put({ x: 2, y, attr: { dim: !isSelected } }, `${String(i).padStart(3, " ")}.`);
+    buffer.put({ x: 8, y, attr: { bold: isSelected, inverse: isSelected } }, `entry-${i}.log`);
     buffer.put({ x: 25, y, attr: { dim: true } }, `${(i * 1024 + 512).toLocaleString()} B`);
   }
 }
@@ -184,9 +174,7 @@ async function runInkCompat(config: ScenarioConfig): Promise<BenchMetrics> {
     for (let i = 0; i < config.warmup; i++) {
       selected = (selected + 1) % LIST_SIZE;
       const frameP = backend.waitForFrame();
-      instance.rerender(
-        reactListTree(React, InkCompat, selected) as React.ReactNode,
-      );
+      instance.rerender(reactListTree(React, InkCompat, selected) as React.ReactNode);
       await frameP;
     }
 
@@ -197,9 +185,7 @@ async function runInkCompat(config: ScenarioConfig): Promise<BenchMetrics> {
       async () => {
         selected = (selected + 1) % LIST_SIZE;
         const frameP = backend.waitForFrame();
-        instance.rerender(
-          reactListTree(React, InkCompat, selected) as React.ReactNode,
-        );
+        instance.rerender(reactListTree(React, InkCompat, selected) as React.ReactNode);
         await frameP;
       },
       0,
@@ -223,24 +209,19 @@ async function runInk(config: ScenarioConfig): Promise<BenchMetrics> {
 
   let selected = 0;
   const initialWrite = stdout.waitForWrite();
-  const instance = Ink.render(
-    reactListTree(React, Ink, selected) as React.ReactNode,
-    {
-      stdout: stdout as unknown as NodeJS.WriteStream,
-      stdin: stdin as unknown as NodeJS.ReadStream,
-      patchConsole: false,
-      exitOnCtrlC: false,
-    },
-  );
+  const instance = Ink.render(reactListTree(React, Ink, selected) as React.ReactNode, {
+    stdout: stdout as unknown as NodeJS.WriteStream,
+    stdin: stdin as unknown as NodeJS.ReadStream,
+    patchConsole: false,
+    exitOnCtrlC: false,
+  });
   await initialWrite;
 
   try {
     for (let i = 0; i < config.warmup; i++) {
       selected = (selected + 1) % LIST_SIZE;
       const writeP = stdout.waitForWrite();
-      instance.rerender(
-        reactListTree(React, Ink, selected) as React.ReactNode,
-      );
+      instance.rerender(reactListTree(React, Ink, selected) as React.ReactNode);
       await writeP;
     }
 
@@ -251,9 +232,7 @@ async function runInk(config: ScenarioConfig): Promise<BenchMetrics> {
       async () => {
         selected = (selected + 1) % LIST_SIZE;
         const writeP = stdout.waitForWrite();
-        instance.rerender(
-          reactListTree(React, Ink, selected) as React.ReactNode,
-        );
+        instance.rerender(reactListTree(React, Ink, selected) as React.ReactNode);
         await writeP;
       },
       0,
@@ -315,16 +294,23 @@ function buildInitialBlessedList(
   blessed: { text: (opts: Record<string, unknown>) => unknown },
   screen: { append: (el: unknown) => void },
   selected: number,
-): { headerSel: BlessedWidget; markers: BlessedWidget[]; indices: BlessedWidget[]; names: BlessedWidget[] } {
+): {
+  headerSel: BlessedWidget;
+  markers: BlessedWidget[];
+  indices: BlessedWidget[];
+  names: BlessedWidget[];
+} {
   // Header
   screen.append(
     blessed.text({ top: 0, left: 0, content: "Files", style: { bold: true }, tags: false }),
   );
-  screen.append(
-    blessed.text({ top: 0, left: 8, content: `${LIST_SIZE} items`, tags: false }),
-  );
+  screen.append(blessed.text({ top: 0, left: 8, content: `${LIST_SIZE} items`, tags: false }));
   const headerSel = blessed.text({
-    top: 0, left: 22, content: `Selected: ${selected}`, style: { fg: "grey" }, tags: false,
+    top: 0,
+    left: 22,
+    content: `Selected: ${selected}`,
+    style: { fg: "grey" },
+    tags: false,
   });
   screen.append(headerSel);
 
@@ -335,10 +321,34 @@ function buildInitialBlessedList(
   for (let i = 0; i < LIST_SIZE; i++) {
     const y = 2 + i;
     const isSel = i === selected;
-    const marker = blessed.text({ top: y, left: 0, content: isSel ? ">" : " ", style: { bold: isSel }, tags: false });
-    const idx = blessed.text({ top: y, left: 2, content: `${String(i).padStart(3, " ")}.`, style: { fg: isSel ? "white" : "grey" }, tags: false });
-    const name = blessed.text({ top: y, left: 8, content: `entry-${i}.log`, style: { bold: isSel, inverse: isSel }, tags: false });
-    const size = blessed.text({ top: y, left: 25, content: `${(i * 1024 + 512).toLocaleString()} B`, style: { fg: "grey" }, tags: false });
+    const marker = blessed.text({
+      top: y,
+      left: 0,
+      content: isSel ? ">" : " ",
+      style: { bold: isSel },
+      tags: false,
+    });
+    const idx = blessed.text({
+      top: y,
+      left: 2,
+      content: `${String(i).padStart(3, " ")}.`,
+      style: { fg: isSel ? "white" : "grey" },
+      tags: false,
+    });
+    const name = blessed.text({
+      top: y,
+      left: 8,
+      content: `entry-${i}.log`,
+      style: { bold: isSel, inverse: isSel },
+      tags: false,
+    });
+    const size = blessed.text({
+      top: y,
+      left: 25,
+      content: `${(i * 1024 + 512).toLocaleString()} B`,
+      style: { fg: "grey" },
+      tags: false,
+    });
     screen.append(marker);
     screen.append(idx);
     screen.append(name);
@@ -356,7 +366,12 @@ function buildInitialBlessedList(
  * matching the partial-update behavior measured by other frameworks.
  */
 function updateBlessedSelection(
-  refs: { headerSel: BlessedWidget; markers: BlessedWidget[]; indices: BlessedWidget[]; names: BlessedWidget[] },
+  refs: {
+    headerSel: BlessedWidget;
+    markers: BlessedWidget[];
+    indices: BlessedWidget[];
+    names: BlessedWidget[];
+  },
   oldSel: number,
   newSel: number,
 ): void {
@@ -424,8 +439,7 @@ async function runRatatui(config: ScenarioConfig): Promise<BenchMetrics> {
 
 export const contentUpdateScenario: Scenario = {
   name: "content-update",
-  description:
-    "Partial screen update: move selection in a 500-row list (measures diff efficiency)",
+  description: "Partial screen update: move selection in a 500-row list (measures diff efficiency)",
   defaultConfig: { warmup: 50, iterations: 500 },
   paramSets: [{}],
   frameworks: ["rezi-native", "ink-compat", "ink", "terminal-kit", "blessed", "ratatui"],

packages/bench/src/scenarios/memory.ts

@@ -13,14 +13,7 @@
 
 import { type VNode, ui } from "@rezi-ui/core";
 import { BenchBackend, MeasuringStream, NullReadable } from "../backends.js";
-import {
-  computeStats,
-  diffCpu,
-  peakMemory,
-  takeCpu,
-  takeMemory,
-  tryGc,
-} from "../measure.js";
+import { computeStats, diffCpu, peakMemory, takeCpu, takeMemory, tryGc } from "../measure.js";
 import type {
   BenchMetrics,
   Framework,
@@ -345,10 +338,7 @@ function termkitMemTree(
   const bar = `[${"#".repeat(filled)}${".".repeat(20 - filled)}] ${pct}%`;
   buffer.put({ x: 1, y: 1 }, bar);
   for (let j = 0; j < 20; j++) {
-    buffer.put(
-      { x: 1, y: 3 + j, attr: { dim: j % 2 === 0 } },
-      `  Line ${j}: value=${i * 20 + j}`,
-    );
+    buffer.put({ x: 1, y: 3 + j, attr: { dim: j % 2 === 0 } }, `  Line ${j}: value=${i * 20 + j}`);
   }
 }
 
@@ -437,9 +427,7 @@ function blessedMemTree(
   const pct = i % 100;
   const filled = Math.floor(pct / 5);
   const bar = `[${"#".repeat(filled)}${".".repeat(20 - filled)}] ${pct}%`;
-  screen.append(
-    blessed.text({ top: 1, left: 1, content: bar, tags: false }),
-  );
+  screen.append(blessed.text({ top: 1, left: 1, content: bar, tags: false }));
   for (let j = 0; j < 20; j++) {
     screen.append(
       blessed.text({