Skip to content

Commit 9f52a4d

Browse files
committed
重命名为 xy_quiet_cmd()
1 parent cf07b13 commit 9f52a4d

File tree

6 files changed

+23
-26
lines changed

6 files changed

+23
-26
lines changed

lib/xy.h

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -491,19 +491,6 @@ xy_streql_ic(const char *str1, const char *str2)
491491
}
492492

493493

494-
static char *
495-
xy_str_to_quietcmd (const char *cmd)
496-
{
497-
char *ret = NULL;
498-
#ifdef _WIN32
499-
ret = xy_2strcat (cmd, " >nul 2>nul ");
500-
#else
501-
ret = xy_2strcat (cmd, " 1>/dev/null 2>&1 ");
502-
#endif
503-
return ret;
504-
}
505-
506-
507494
/**
508495
* @flavor Ruby: String#end_with?
509496
*/
@@ -776,9 +763,23 @@ _xy_log_brkt (int level, const char *prompt1, const char *prompt2, const char *c
776763

777764

778765
/******************************************************
779-
* System
766+
* cross OS
780767
******************************************************/
781768

769+
static char *
770+
xy_quiet_cmd (const char *cmd)
771+
{
772+
char *ret = NULL;
773+
774+
if (xy.on_windows)
775+
ret = xy_2strcat (cmd, " >nul 2>nul ");
776+
else
777+
ret = xy_2strcat (cmd, " 1>/dev/null 2>&1 ");
778+
779+
return ret;
780+
}
781+
782+
782783
/**
783784
* @brief 执行 `cmd`,返回某行输出结果,并对已经遍历过的行执行 `func`
784785
*
@@ -845,7 +846,7 @@ xy_run (const char *cmd, unsigned long n)
845846
int
846847
xy_run_get_status (char *cmd)
847848
{
848-
char * command = xy_str_to_quietcmd (cmd);
849+
char * command = xy_quiet_cmd (cmd);
849850

850851
int status = system (command);
851852
return status;
@@ -896,10 +897,6 @@ xy_run_get_stdout (const char *cmd, char **output)
896897
}
897898

898899

899-
/******************************************************
900-
* cross OS
901-
******************************************************/
902-
903900
/**
904901
* @flavor 该函数同 just 中的 os_family(),只区分 windows, unix
905902
*

src/chsrc-main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ cli_print_issues ()
443443
/*
444444
if (chsrc_check_program ("gh"))
445445
{
446-
char *cmd = xy_str_to_quietcmd ("gh browse --repo RubyMetric/chsrc");
446+
char *cmd = xy_quiet_cmd ("gh browse --repo RubyMetric/chsrc");
447447
system (cmd);
448448
}
449449
*/

src/framework/core.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ cmd_to_check_program (char *prog_name)
383383
{
384384
char *check_tool = xy.on_windows ? "where " : "command -v ";
385385

386-
char *quiet_cmd = xy_str_to_quietcmd (xy_2strcat (check_tool, prog_name));
386+
char *quiet_cmd = xy_quiet_cmd (xy_2strcat (check_tool, prog_name));
387387

388388
return quiet_cmd;
389389
}
@@ -402,7 +402,7 @@ XY_Deprecate_This("Use cmd_to_check_program() instead")
402402
static char *
403403
cmd_to_check_program2 (char *prog_name)
404404
{
405-
char *quiet_cmd = xy_str_to_quietcmd (xy_2strcat (prog_name, " --version"));
405+
char *quiet_cmd = xy_quiet_cmd (xy_2strcat (prog_name, " --version"));
406406
return quiet_cmd;
407407
}
408408

@@ -1595,7 +1595,7 @@ chsrc_ensure_dir (const char *dir)
15951595
mkdir_cmd = "mkdir -p ";
15961596
}
15971597
char *cmd = xy_2strcat (mkdir_cmd, dir);
1598-
cmd = xy_str_to_quietcmd (cmd);
1598+
cmd = xy_quiet_cmd (cmd);
15991599

16001600
chsrc_run_as_a_service (cmd);
16011601

src/recipe/lang/Go.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ pl_go_prelude ()
5353
void
5454
pl_go_check_cmd ()
5555
{
56-
char *check_cmd = xy_str_to_quietcmd ("go version");
56+
char *check_cmd = xy_quiet_cmd ("go version");
5757
bool exist = query_program_exist (check_cmd, "go", Noisy_When_Exist|Noisy_When_NonExist);
5858

5959
if (!exist)

src/recipe/lang/JavaScript/Yarn.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ pl_js_yarn_setsrc (char *option)
7878
// 不能直接退出,因为 Leader target 不能就此结束
7979
return;
8080
}
81-
// 不再阻止换源命令输出到终端,即不再调用 xy_str_to_quietcmd()
81+
// 不再阻止换源命令输出到终端,即不再调用 xy_quiet_cmd()
8282
cmd = xy_2strcat ("yarn config set registry ", source.url);
8383
chsrc_run (cmd, RunOpt_No_Last_New_Line);
8484
}

src/recipe/os/BSD/FreeBSD.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ os_freebsd_setsrc (char *option)
7575
// @ccmywish: 2023-09-27 据 @ykla , NJU的freebsd-ports源没有设置 Git,
7676
// 但是我认为由于使用Git还是要比非Git方便许多,我们尽可能坚持使用Git
7777
// 而 gitup 又要额外修改它自己的配置,比较麻烦
78-
bool git_exist = query_program_exist (xy_str_to_quietcmd ("git version"), "git", Noisy_When_Exist|Noisy_When_NonExist);
78+
bool git_exist = query_program_exist (xy_quiet_cmd ("git version"), "git", Noisy_When_Exist|Noisy_When_NonExist);
7979
if (git_exist)
8080
{
8181
if (xy_streql("nju",source.mirror->code))

0 commit comments

Comments
 (0)