forked from thoughtbot/trail-map
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathcode-review.json
More file actions
70 lines (70 loc) · 2.31 KB
/
code-review.json
File metadata and controls
70 lines (70 loc) · 2.31 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
{
"name": "Code Review",
"description": "A peer review of source code. It is intended to find and fix mistakes overlooked in the initial development phase, improving both the overall quality of software and the developers' skills.",
"steps": [
{
"name": "Beginning Code Review",
"level": "beginner",
"resources": [
{
"title": "Feature branch code reviews",
"uri": "http://smartbear.com/SmartBear/media/pdfs/WP-CC-11-Best-Practices-of-Peer-Code-Review.pdf",
"id": "7702effa2708d62e70512aefb47d19df37e9c7f0"
},
{
"title": "Best practices of peer code review",
"uri": "http://goo.gl/A8Boc",
"id": "962c93403800b355f2e1fef25774988934abf1a5"
}
],
"validations": [
{
"title": "Comment on a specific line number.",
"id": "31fc572ac42eed77b4b27658041336fed9637fbc"
},
{
"title": "Comment constructively and politely.",
"id": "b2c808b778e1a8dda92ebe4a69082e76f416ae7b"
},
{
"title": "Learn something valuable from the comments.",
"id": "429bd428337ee50b0dc4a1ce1e9c64fb3e97b95a"
},
{
"title": "Express appreciation to the author.",
"id": "34d87d67d8cb968e2d25efa505e2f4691eb2f3b8"
},
{
"title": "Review the code in a timely manner.",
"id": "d0849504f2f40cfaa37f953b7181d977fd61fffb"
}
]
},
{
"name": "Intermediate Code Review",
"level": "intermediate",
"validations": [
{
"title": "Create small pull requests, which are easier to review.",
"id": "2de53d8e214022246201df088f59b14ddb10812a"
},
{
"title": "Take comments as constructive and not personal criticism.",
"id": "41c368f8a94057ba3dcde034adfc6d260dcc4089"
},
{
"title": "Learn something valuable from the comments.",
"id": "429bd428337ee50b0dc4a1ce1e9c64fb3e97b95a"
},
{
"title": "Express appreciation to the reviewer.",
"id": "570f8dba353eddb1411a8e838eecc9211734cbda"
},
{
"title": "Respond to comments in a timely manner.",
"id": "4cee88824647ef8ceebc0619b802a9dd8b258720"
}
]
}
]
}