unchecking games during scan yields strange behavior

[catharsis71]

when you uncheck a game during a scan, it appears to continue scanning for additional matches for that game, however, any matches found during this period will not appear if the game is later checked back on, only matches found prior to the initial unchecking will (re)appear, as well as matches found after checking the game back on. matches found while the game was unchecked appear to exist invisibly, and evidence of this can be found when using the "Offer a trade for all" button.

for example:

1. start scan
2. get match for game A
3. uncheck game A
4. wait for invisible matches of game A to happen
5. check game A back on (older matches will reappear but not the invisible matches that happened while game A was unchecked)
6. click "Offer a trade for all" on a user that has a visible match for game B and invisible match for game A
7. the trade window will incorporate cards for both game A and game B

[iBreakEverything]

It's possible as the new matches will have a "Offer a trade for all" button containing all the badges. The filter process updates all the existing buttons. A solution would be to apply the filter function on the button as soon as a scanRow is inserted.

[iBreakEverything]

A fix has been deployed. The cause of this was an additional redundant check on adding a matchTemplate (single badge match with one bot) into the rowTemplate (all matches with one bot). By removing the conditional from the following code the bug was fixed and filter functionality was not affected.

//if (checkBox === null || checkBox.checked) {
    matches += matchTemplate;
//}