fix(swift): v0.19.1 - address PR review comments

- Fix VLM pixel format mismatch: RGBX→RGB stripping for macOS NSImage
- Fix VLM silent failure: report error when cgImage conversion fails
- Fix particle view transparency: set wantsLayer before layer config
- Fix toolbar placement: cancellationAction→automatic for nav buttons
- Remove tvOS/watchOS from platforms (no binary slices available)
- Remove non-deterministic FileManager check from Package.swift
- Quote shell command substitutions (SC2046)

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: sanchitmonga22

Package.swift

@@ -18,12 +18,8 @@ import Foundation
 //
 // =============================================================================
 
-// Get the package directory for relative path resolution
-let packageDir = URL(fileURLWithPath: #file).deletingLastPathComponent().path
-
-// Path to combined ONNX Runtime xcframework (iOS + macOS)
-// Created by: cd sdk/runanywhere-swift && ./scripts/create-onnxruntime-xcframework.sh
-let onnxRuntimeLocalPath = "\(packageDir)/sdk/runanywhere-swift/Binaries/onnxruntime.xcframework"
+// Combined ONNX Runtime xcframework (local dev) is created by:
+//   cd sdk/runanywhere-swift && ./scripts/create-onnxruntime-xcframework.sh
 
 // =============================================================================
 // BINARY TARGET CONFIGURATION
@@ -45,15 +41,13 @@ let useLocalBinaries = false //  Toggle: true for local dev, false for release
 
 // Version for remote XCFrameworks (used when testLocal = false)
 // Updated automatically by CI/CD during releases
-let sdkVersion = "0.19.0"
+let sdkVersion = "0.19.1"
 
 let package = Package(
     name: "runanywhere-sdks",
     platforms: [
         .iOS(.v17),
         .macOS(.v14),
-        .tvOS(.v17),
-        .watchOS(.v10)
     ],
     products: [
         // =================================================================
@@ -219,24 +213,14 @@ func binaryTargets() -> [Target] {
             ),
         ]
 
-        // Use local combined ONNX Runtime xcframework if available (includes macOS),
-        // otherwise fall back to iOS-only pod archive from onnxruntime.ai
-        if FileManager.default.fileExists(atPath: onnxRuntimeLocalPath) {
-            targets.append(
-                .binaryTarget(
-                    name: "ONNXRuntimeBinary",
-                    path: "sdk/runanywhere-swift/Binaries/onnxruntime.xcframework"
-                )
-            )
-        } else {
-            targets.append(
-                .binaryTarget(
-                    name: "ONNXRuntimeBinary",
-                    url: "https://download.onnxruntime.ai/pod-archive-onnxruntime-c-1.17.1.zip",
-                    checksum: "9a2d54d4f503fbb82d2f86361a1d22d4fe015e2b5e9fb419767209cc9ab6372c"
-                )
+        // Local combined ONNX Runtime xcframework (iOS + macOS)
+        // Created by: cd sdk/runanywhere-swift && ./scripts/create-onnxruntime-xcframework.sh
+        targets.append(
+            .binaryTarget(
+                name: "ONNXRuntimeBinary",
+                path: "sdk/runanywhere-swift/Binaries/onnxruntime.xcframework"
             )
-        }
+        )
 
         return targets
     } else {

examples/ios/RunAnywhereAI/RunAnywhereAI/Features/Chat/Views/ChatInterfaceView.swift

@@ -140,7 +140,7 @@ extension ChatInterfaceView {
                         modelButton
                     }
                     #else
-                    ToolbarItem(placement: .cancellationAction) {
+                    ToolbarItem(placement: .automatic) {
                         Button {
                             showingConversationList = true
                         } label: {

examples/ios/RunAnywhereAI/RunAnywhereAI/Features/Vision/VLMViewModel.swift

@@ -192,25 +192,43 @@ final class VLMViewModel: NSObject {
 
         do {
             guard let cgImage = nsImage.cgImage(forProposedRect: nil, context: nil, hints: nil) else {
+                let conversionError = NSError(
+                    domain: "com.runanywhere.RunAnywhereAI",
+                    code: -1,
+                    userInfo: [NSLocalizedDescriptionKey: "Failed to convert NSImage to CGImage"]
+                )
+                self.error = conversionError
+                logger.error("VLM error: failed to convert NSImage to CGImage")
                 isProcessing = false
                 return
             }
             let width = cgImage.width
             let height = cgImage.height
-            let bytesPerRow = 4 * width
-            var rgbData = Data(count: bytesPerRow * height)
-            rgbData.withUnsafeMutableBytes { ptr in
+            let rgbaBytesPerRow = 4 * width
+            let rgbaTotalBytes = rgbaBytesPerRow * height
+            var rgbaData = Data(count: rgbaTotalBytes)
+            rgbaData.withUnsafeMutableBytes { ptr in
                 guard let context = CGContext(
                     data: ptr.baseAddress,
                     width: width,
                     height: height,
                     bitsPerComponent: 8,
-                    bytesPerRow: bytesPerRow,
+                    bytesPerRow: rgbaBytesPerRow,
                     space: CGColorSpaceCreateDeviceRGB(),
                     bitmapInfo: CGImageAlphaInfo.noneSkipLast.rawValue
                 ) else { return }
                 context.draw(cgImage, in: CGRect(x: 0, y: 0, width: width, height: height))
             }
+            // RGBX (4 bytes/pixel) → RGB (3 bytes/pixel): strip the padding byte
+            var rgbData = Data(capacity: width * height * 3)
+            rgbaData.withUnsafeBytes { buffer in
+                let pixels = buffer.bindMemory(to: UInt8.self)
+                for i in stride(from: 0, to: rgbaTotalBytes, by: 4) {
+                    rgbData.append(pixels[i])     // R
+                    rgbData.append(pixels[i + 1]) // G
+                    rgbData.append(pixels[i + 2]) // B
+                }
+            }
             let image = VLMImage(rgbPixels: rgbData, width: width, height: height)
             let result = try await RunAnywhere.processImageStream(
                 image,

examples/ios/RunAnywhereAI/RunAnywhereAI/Features/Voice/VoiceAssistantParticleView.swift

@@ -404,6 +404,7 @@ struct VoiceAssistantParticleView: NSViewRepresentable {
         view.preferredFramesPerSecond = 60
         view.isPaused = false
         view.enableSetNeedsDisplay = false
+        view.wantsLayer = true
         view.layer?.isOpaque = false
 
         if let device = view.device {

sdk/runanywhere-commons/scripts/build-ios.sh

@@ -213,7 +213,7 @@ build_macos() {
         -DRAC_BUILD_JNI=OFF \
         $BACKEND_FLAGS
 
-    cmake --build . --config "${BUILD_TYPE}" -j$(sysctl -n hw.ncpu)
+    cmake --build . --config "${BUILD_TYPE}" -j"$(sysctl -n hw.ncpu)"
 
     cd "${PROJECT_ROOT}"
     log_info "Built macOS arm64"
@@ -261,7 +261,7 @@ build_platform() {
         -DRAC_BUILD_JNI=OFF \
         $BACKEND_FLAGS
 
-    cmake --build . --config "${BUILD_TYPE}" -j$(sysctl -n hw.ncpu)
+    cmake --build . --config "${BUILD_TYPE}" -j"$(sysctl -n hw.ncpu)"
 
     cd "${PROJECT_ROOT}"
     log_info "Built ${PLATFORM}"

sdk/runanywhere-commons/scripts/macos/download-sherpa-onnx.sh

@@ -86,7 +86,7 @@ cmake "${BUILD_TEMP}/sherpa-onnx" \
     -DSHERPA_ONNX_ENABLE_WEBSOCKET=OFF \
     -DSHERPA_ONNX_ENABLE_GPU=OFF
 
-cmake --build . --config Release -j$(sysctl -n hw.ncpu)
+cmake --build . --config Release -j"$(sysctl -n hw.ncpu)"
 
 # Collect static libraries and headers
 echo ""