Skip to content

Commit 8316969

Browse files
chore: Enhance RACommons CI workflow for iOS and Android packaging
- Updated iOS packaging to always create a versioned zip file from the release tag. - Improved Android artifact structure handling by correcting paths and adding logging for copied libraries. - Clarified documentation regarding the contents of the packaged Android libraries. - Ensured consistent versioning in release assets for both platforms.
1 parent 27bf21c commit 8316969

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

.github/workflows/commons-release.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -189,27 +189,24 @@ jobs:
189189
VERSION="${{ needs.build-ios.outputs.version }}"
190190
mkdir -p release-assets
191191
192-
# iOS assets
193-
if [ -d dist/ios/packages ]; then
194-
cp dist/ios/packages/*.zip release-assets/ 2>/dev/null || true
195-
cp dist/ios/packages/*.sha256 release-assets/ 2>/dev/null || true
196-
fi
197-
198-
# Package iOS XCFramework if not already packaged
199-
if [ -d dist/ios/RACommons.xcframework ] && [ ! -f release-assets/*ios*.zip ]; then
192+
# iOS: Always create package with correct version from release tag
193+
if [ -d dist/ios/RACommons.xcframework ]; then
200194
cd dist/ios
201195
zip -r "../../release-assets/RACommons-ios-v${VERSION}.zip" RACommons.xcframework
202196
cd ../../release-assets
203197
shasum -a 256 "RACommons-ios-v${VERSION}.zip" > "RACommons-ios-v${VERSION}.zip.sha256"
198+
cd ..
204199
fi
205200
206201
# Combine Android ABIs
202+
# Note: artifact structure is dist/android-artifacts/racommons-android-{abi}-{ver}/jniLibs/{abi}/
207203
mkdir -p android-combined/jniLibs
208-
for dir in dist/android-artifacts/racommons-android-*/android/jniLibs/*/; do
204+
for dir in dist/android-artifacts/racommons-android-*/jniLibs/*/; do
209205
if [ -d "$dir" ]; then
210206
abi=$(basename "$dir")
211207
mkdir -p "android-combined/jniLibs/${abi}"
212208
cp -r "${dir}"* "android-combined/jniLibs/${abi}/" 2>/dev/null || true
209+
echo "Copied libs for ${abi}: $(ls android-combined/jniLibs/${abi}/ 2>/dev/null | wc -l) files"
213210
fi
214211
done
215212
@@ -221,6 +218,8 @@ jobs:
221218
222219
# Package Android
223220
cd android-combined
221+
echo "=== Android Combined Contents ==="
222+
find . -type f | head -20
224223
zip -r "../release-assets/RACommons-android-v${VERSION}.zip" .
225224
cd ../release-assets
226225
shasum -a 256 "RACommons-android-v${VERSION}.zip" > "RACommons-android-v${VERSION}.zip.sha256"
@@ -253,7 +252,8 @@ jobs:
253252
254253
### Android
255254
`RACommons-android-v${{ needs.build-ios.outputs.version }}.zip`
256-
- Contains `jniLibs/{abi}/librac_commons.so`
255+
- Contains `jniLibs/{abi}/librac_commons.so` (core library)
256+
- Contains `jniLibs/{abi}/librunanywhere_jni.so` (JNI bridge for Kotlin SDK)
257257
- Contains `include/` headers
258258
259259
### Note

0 commit comments

Comments
 (0)