Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Commit 252f55b

Browse files
authored
Merge branch 'main' into python-version-update
2 parents 6f32b5d + a49944d commit 252f55b

File tree

5 files changed

+37
-115
lines changed

5 files changed

+37
-115
lines changed

bookserver/internal/feedback.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ def _platform_edit(
250250
ext = os.path.splitext(source_path)[1]
251251
if ext == ".c":
252252
fmt = '#line 1 "box {}"\n'
253-
elif ext == ".s":
253+
elif ext == ".s" or ext == ".S":
254254
# I can't get this to work in the `gnu assembler <https://gcc.gnu.org/onlinedocs/cpp/Line-Control.html>`_. I tried:
255255
#
256256
# - From Section 4.11 (Misc directives):

bookserver/routers/books.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import os.path
1616
import posixpath
1717
import random
18+
import socket
1819
from typing import Optional
1920

2021
# Third-party imports
@@ -304,6 +305,7 @@ async def serve_page(
304305
show_rs_banner = False
305306
rslogger.debug(f"After user check rs_banner is {show_rs_banner}")
306307

308+
worker_name = os.environ.get("WORKER_NAME", socket.gethostname())
307309
# temporary
308310
if course_attrs.get("ad_server", "google") == "ethical":
309311
serve_google_ad = False
@@ -331,6 +333,7 @@ async def serve_page(
331333
canonical_host=canonical_host,
332334
show_rs_banner=show_rs_banner,
333335
show_ethical_ad=serve_ad,
336+
worker_name=worker_name,
334337
**course_attrs,
335338
)
336339
# See `templates <https://fastapi.tiangolo.com/advanced/templates/>`_.

bookserver/routers/rslogging.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,9 @@ async def updatelastpage(
267267
RS_info: Optional[str] = Cookie(None),
268268
):
269269
if request_data.last_page_url is None:
270-
return # todo: log request_data, request.args and request.env.path_info
270+
rslogger.error(f"No data for last page url {request_data}")
271+
return make_json_response(detail="No Data")
272+
# todo: log request_data, request.args and request.env.path_info
271273
if request.state.user:
272274
lpd = request_data.dict()
273275
rslogger.debug(f"{lpd=}")

0 commit comments

Comments
 (0)