Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Commit 69d7697

Browse files
committed
Fix: Do not send log request if user logged out
When a user is not logged in logging results in a 401 error. This is just useless network traffic and load on the server.
1 parent 85da2dd commit 69d7697

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

runestone/common/js/runestonebase.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,16 @@ export default class RunestoneBase {
9494
if (this.percent) {
9595
eventInfo.percent = this.percent;
9696
}
97-
if (eBookConfig.useRunestoneServices && eBookConfig.logLevel > 0) {
97+
if (
98+
eBookConfig.isLoggedIn &&
99+
eBookConfig.useRunestoneServices &&
100+
eBookConfig.logLevel > 0
101+
) {
98102
post_return = this.postLogMessage(eventInfo);
99103
}
100104
if (!this.isTimed || eBookConfig.debug) {
101-
console.log("logging event " + JSON.stringify(eventInfo));
105+
let prefix = eBookConfig.isLoggedIn ? "Save" : "Not";
106+
console.log(`${prefix} logging event ` + JSON.stringify(eventInfo));
102107
}
103108
// When selectquestions are part of an assignment especially toggle questions
104109
// we need to count using the selector_id of the select question.
@@ -185,7 +190,11 @@ export default class RunestoneBase {
185190
if (this.forceSave || "to_save" in eventInfo === false) {
186191
eventInfo.save_code = "True";
187192
}
188-
if (eBookConfig.useRunestoneServices && eBookConfig.logLevel > 0) {
193+
if (
194+
eBookConfig.isLoggedIn &&
195+
eBookConfig.useRunestoneServices &&
196+
eBookConfig.logLevel > 0
197+
) {
189198
let request = new Request(
190199
`${eBookConfig.new_server_prefix}/logger/runlog`,
191200
{

0 commit comments

Comments
 (0)