✅ Fixing tests for hparsons

Author: zihan21206

runestone/hparsons/test/test_hparsons.py

@@ -17,6 +17,79 @@ def click_control(hp_question, button_name):
     btn = hp_question.find_element(By.CSS_SELECTOR, css)
     btn.click()
 
+"""
+Test Block Based feedback is correct:
+1-1. Click on three blocks to form a solution that does not have enough blocks
+1-2. Click on run button to check the result is hinting missing blocks
+2-1. Click on more blocks to form an incorrect solution
+2-2. Click on run button to check the result is hinting incorrect, and incorrect blocks are highlight correctly
+3-1. Click to change to the correct answer
+3-2. Click on run button to check the result is hinting that they completed in 3 attempts
+3-3. Check the run button is disabled 
+4-1. Click on reset button
+4-2. Form a correct solution
+4-3. Click on run button to check the result is hinting completed in one attempt
+"""
+def test_run_block(selenium_utils_get):
+    div_id = "test_hparsons_block_1"
+    hp_question = find_hp_question(selenium_utils_get, div_id) 
+    hp = hp_question.find_element(By.CSS_SELECTOR, 'horizontal-parsons')
+    drag_area = hp.find_element(By.CSS_SELECTOR, '.drag-area')
+    drop_area = hp.find_element(By.CSS_SELECTOR, '.drop-area')
+    run_btn = hp_question.find_elements(By.TAG_NAME, 'button')[0]
+    reset_btn = hp_question.find_elements(By.TAG_NAME, 'button')[1]
+
+    time.sleep(5)
+    # 1-1. Click on three blocks to form a solution that does not have enough blocks
+    for code_piece in ['SELECT', '*', 'test']:
+        blocks = drag_area.find_elements(By.CSS_SELECTOR, '.parsons-block')
+        for block in blocks:
+            if block.text == code_piece:
+                time.sleep(1)
+                block.click()
+                break
+    # 1-2. Click on run button to check the result is hinting missing blocks
+    run_btn.click()
+    feedback_area = hp_question.find_element(By.CLASS_NAME, 'alert')
+    assert 'Your program is too short.' in feedback_area.text
+
+    # 2-1. Click on more blocks to form an incorrect solution
+    block = drag_area.find_element(By.CSS_SELECTOR, '.parsons-block')
+    block.click()
+    # 2-2. Click on run button to check the result is hinting incorrect, and incorrect blocks are highlight correctly
+    run_btn.click()
+    time.sleep(1)
+    feedback_area = hp_question.find_element(By.CLASS_NAME, 'alert')
+    assert 'Highlighted blocks in your program are wrong or are in the wrong order.' in feedback_area.text
+    highlighted_blocks = []
+    for block in drop_area.find_elements(By.CSS_SELECTOR, '.parsons-block.incorrectPosition'):
+        highlighted_blocks.append(block.text)
+    assert set(highlighted_blocks) == set(['FROM'])
+
+    # 3-1. Click to change to the correct answer
+    drop_area.find_elements(By.CSS_SELECTOR, '.parsons-block')[2].click()
+    drag_area.find_element(By.CSS_SELECTOR, '.parsons-block').click()
+    # 3-2. Click on run button to check the result is hinting that they completed in 3 attempts
+    run_btn.click()
+    feedback_area = hp_question.find_element(By.CLASS_NAME, 'alert')
+    assert 'It took you 3 tries to solve this.' in feedback_area.text
+    # 3-3. Check the run button is disabled
+    assert run_btn.get_attribute('disabled') == 'true'
+
+    # 4-1. Click on reset button
+    reset_btn.click()
+    # 4-2. Form a correct solution
+    for code_piece in ['SELECT', '*', 'FROM', 'test']:
+        blocks = drag_area.find_elements(By.CSS_SELECTOR, '.parsons-block')
+        for block in blocks:
+            if block.text == code_piece:
+                block.click()
+    # 4-3. Click on run button to check the result is hinting completed in one attempt
+    run_btn.click()
+    feedback_area = hp_question.find_element(By.CLASS_NAME, 'alert')
+    assert 'It took you only one try to solve this.' in feedback_area.text
+
+    
 '''
 Test if the blocks are properly randomized.
 1. Assert the sequence of the blocks is not the same as set in .rst file.
@@ -26,7 +99,7 @@ def test_randomize_block(selenium_utils_get):
     hp = find_hp_question(selenium_utils_get, div_id).find_element(By.CSS_SELECTOR, 'horizontal-parsons')
     original_sequence = ['SELECT','*','FROM','test']
     randomized_sequence = []
-    for block in hp.shadow_root.find_element(By.CSS_SELECTOR,'.drag-area').find_elements(By.CSS_SELECTOR, '.parsons-block'):
+    for block in hp.find_element(By.CSS_SELECTOR,'.drag-area').find_elements(By.CSS_SELECTOR, '.parsons-block'):
         randomized_sequence.append(block.text)
     assert len(original_sequence) == len(randomized_sequence)
     is_same_order = True
@@ -49,8 +122,8 @@ def test_randomize_block(selenium_utils_get):
 def test_add_and_remove_blocks(selenium_utils_get):
     div_id = "test_hparsons_sql_1"
     hp = find_hp_question(selenium_utils_get, div_id).find_element(By.CSS_SELECTOR, 'horizontal-parsons')
-    drag_area = hp.shadow_root.find_element(By.CSS_SELECTOR, '.drag-area')
-    drop_area = hp.shadow_root.find_element(By.CSS_SELECTOR, '.drop-area')
+    drag_area = hp.find_element(By.CSS_SELECTOR, '.drag-area')
+    drop_area = hp.find_element(By.CSS_SELECTOR, '.drop-area')
 
     # 1. Click on the first block and make sure it is added to the bottom
     block1 = drag_area.find_elements(By.CSS_SELECTOR, '.parsons-block')[0]
@@ -68,8 +141,8 @@ def test_add_and_remove_blocks(selenium_utils_get):
     # For reusable blocks
     div_id = "test_hparsons_sql_2"
     hp = find_hp_question(selenium_utils_get, div_id).find_element(By.CSS_SELECTOR, 'horizontal-parsons')
-    drag_area = hp.shadow_root.find_element(By.CSS_SELECTOR, '.drag-area')
-    drop_area = hp.shadow_root.find_element(By.CSS_SELECTOR, '.drop-area')
+    drag_area = hp.find_element(By.CSS_SELECTOR, '.drag-area')
+    drop_area = hp.find_element(By.CSS_SELECTOR, '.drop-area')
 
     # 1. Click on the first block and make sure it is copied to the bottom
     block1 = drag_area.find_elements(By.CSS_SELECTOR, '.parsons-block')[0]
@@ -95,8 +168,8 @@ def test_run_SQL(selenium_utils_get):
     hp_question = find_hp_question(selenium_utils_get, div_id) 
     time.sleep(2)
     hp = hp_question.find_element(By.CSS_SELECTOR, 'horizontal-parsons')
-    drag_area = hp.shadow_root.find_element(By.CSS_SELECTOR, '.drag-area')
-    drop_area = hp.shadow_root.find_element(By.CSS_SELECTOR, '.drop-area')
+    drag_area = hp.find_element(By.CSS_SELECTOR, '.drag-area')
+    drop_area = hp.find_element(By.CSS_SELECTOR, '.drop-area')
 
     # 1. Click on each of the four blocks in second problem to form a solution
     blocks = drag_area.find_elements(By.CSS_SELECTOR, '.parsons-block')
@@ -111,73 +184,3 @@ def test_run_SQL(selenium_utils_get):
     out = selenium_utils_get.driver.find_element(By.ID, f"{div_id}_stdout")
     assert "You passed 2 out of 3 tests" in out.text
 
-
-"""
-Test Block Based feedback is correct:
-1-1. Click on three blocks to form a solution that does not have enough blocks
-1-2. Click on run button to check the result is hinting missing blocks
-2-1. Click on more blocks to form an incorrect solution
-2-2. Click on run button to check the result is hinting incorrect, and incorrect blocks are highlight correctly
-3-1. Click to change to the correct answer
-3-2. Click on run button to check the result is hinting that they completed in 3 attempts
-3-3. Check the run button is disabled 
-4-1. Click on reset button
-4-2. Form a correct solution
-4-3. Click on run button to check the result is hinting completed in one attempt
-"""
-def test_run_block(selenium_utils_get):
-    div_id = "test_hparsons_block_1"
-    hp_question = find_hp_question(selenium_utils_get, div_id) 
-    hp = hp_question.find_element(By.CSS_SELECTOR, 'horizontal-parsons')
-    drag_area = hp.shadow_root.find_element(By.CSS_SELECTOR, '.drag-area')
-    drop_area = hp.shadow_root.find_element(By.CSS_SELECTOR, '.drop-area')
-    run_btn = hp_question.find_elements(By.TAG_NAME, 'button')[0]
-    reset_btn = hp_question.find_elements(By.TAG_NAME, 'button')[1]
-
-    # 1-1. Click on three blocks to form a solution that does not have enough blocks
-    for code_piece in ['SELECT', '*', 'test']:
-        blocks = drag_area.find_elements(By.CSS_SELECTOR, '.parsons-block')
-        for block in blocks:
-            if block.text == code_piece:
-                block.click()
-    # 1-2. Click on run button to check the result is hinting missing blocks
-    run_btn.click()
-    feedback_area = hp_question.find_element(By.CLASS_NAME, 'alert')
-    assert 'Your program is too short.' in feedback_area.text
-
-    # 2-1. Click on more blocks to form an incorrect solution
-    block = drag_area.find_element(By.CSS_SELECTOR, '.parsons-block')
-    block.click()
-    # 2-2. Click on run button to check the result is hinting incorrect, and incorrect blocks are highlight correctly
-    run_btn.click()
-    time.sleep(1)
-    feedback_area = hp_question.find_element(By.CLASS_NAME, 'alert')
-    assert 'Highlighted blocks in your program are wrong or are in the wrong order.' in feedback_area.text
-    highlighted_blocks = []
-    for block in drop_area.find_elements(By.CSS_SELECTOR, '.parsons-block.incorrectPosition'):
-        highlighted_blocks.append(block.text)
-    assert set(highlighted_blocks) == set(['FROM'])
-
-    # 3-1. Click to change to the correct answer
-    drop_area.find_elements(By.CSS_SELECTOR, '.parsons-block')[2].click()
-    drag_area.find_element(By.CSS_SELECTOR, '.parsons-block').click()
-    # 3-2. Click on run button to check the result is hinting that they completed in 3 attempts
-    run_btn.click()
-    feedback_area = hp_question.find_element(By.CLASS_NAME, 'alert')
-    assert 'It took you 3 tries to solve this.' in feedback_area.text
-    # 3-3. Check the run button is disabled
-    assert run_btn.get_attribute('disabled') == 'true'
-
-    # 4-1. Click on reset button
-    reset_btn.click()
-    # 4-2. Form a correct solution
-    for code_piece in ['SELECT', '*', 'FROM', 'test']:
-        blocks = drag_area.find_elements(By.CSS_SELECTOR, '.parsons-block')
-        for block in blocks:
-            if block.text == code_piece:
-                block.click()
-    # 4-3. Click on run button to check the result is hinting completed in one attempt
-    run_btn.click()
-    feedback_area = hp_question.find_element(By.CLASS_NAME, 'alert')
-    assert 'It took you only one try to solve this.' in feedback_area.text
-