Because of the new changes, I cannot get auth.user.course_name anymore in the assignments.py practice action, instead I get base_course from the course object to mathch with the corresponding db.chapters.course_id.

Author: ImanYZ

controllers/assignments.py

@@ -769,7 +769,7 @@ def practice():
                                                      float(session.timezoneoffset) if 'timezoneoffset' in session else 0)
 
     if message1 != "":
-        session.flash = message1 + " " + message2
+        # session.flash = message1 + " " + message2
         return redirect(URL('practiceNotStartedYet',
                             vars=dict(message1=message1,
                                       message2=message2)))
@@ -781,7 +781,7 @@ def practice():
                         (db.user_topic_practice.user_id == auth.user.id) &
                         (db.user_topic_practice.chapter_label == db.chapters.chapter_label) &
                         (db.user_topic_practice.sub_chapter_label == db.sub_chapters.sub_chapter_label) &
-                        (db.chapters.course_id == auth.user.course_name) &
+                        (db.chapters.course_id == course.base_course) &
                         (db.sub_chapters.chapter_id == db.chapters.id)) \
             .select(db.chapters.chapter_name,
                     db.sub_chapters.sub_chapter_name,
@@ -814,20 +814,31 @@ def practice():
         elif f_card["mastery_percent"] >= 25:
             f_card["mastery_color"] = "warning"
 
-    # If the student has any flashcards to practice and has not practiced enough to get their points for today or they
-    # have intrinsic motivation to practice beyond what they are expected to do.
-    if available_flashcards_num > 0 and (practiced_today_count != questions_to_complete_day or
-                                            request.vars.willing_to_continue or
-                                            spacing == 0):
+    # If an instructor removes the practice flag from a question in the middle of the semester
+    # and students are in the middle of practicing it, the following code makes sure the practice tool does not crash.
+    questions = []
+    if len(presentable_flashcards) > 0:
         # Present the first one.
         flashcard = presentable_flashcards[0]
         # Get eligible questions.
         questions = _get_qualified_questions(course.base_course,
                                              flashcard.chapter_label,
                                              flashcard.sub_chapter_label)
+    # If the student has any flashcards to practice and has not practiced enough to get their points for today or they
+    # have intrinsic motivation to practice beyond what they are expected to do.
+    if (available_flashcards_num > 0 and 
+        len(questions) > 0 and
+        (practiced_today_count != questions_to_complete_day or
+            request.vars.willing_to_continue or
+            spacing == 0)):
         # Find index of the last question asked.
         question_names = [q.name for q in questions]
-        qIndex = question_names.index(flashcard.question_name)
+
+        try:
+            qIndex = question_names.index(flashcard.question_name)
+        except:
+            qIndex = 0
+
         # present the next one in the list after the last one that was asked
         question = questions[(qIndex + 1) % len(questions)]
 
@@ -868,15 +879,15 @@ def practice():
                 course_name=auth.user.course_name,
                 practice_completion_date=now_local.date()
             )
+            practice_completion_count = _get_practice_completion(auth.user.id,
+                                                                    auth.user.course_name,
+                                                                    spacing)
             if practice_graded == 1:
                 # send practice grade via lti, if setup for that
                 lti_record = _get_lti_record(session.oauth_consumer_key)
                 practice_grade = _get_student_practice_grade(auth.user.id, auth.user.course_name)
                 course_settings = _get_course_practice_record(auth.user.course_name)
 
-                practice_completion_count = _get_practice_completion(auth.user.id,
-                                                                     auth.user.course_name,
-                                                                     spacing)
                 if spacing == 1:
                     total_possible_points = day_points * max_days
                     points_received = day_points * practice_completion_count