merge main into async-toggle and resolve conflicts

Author: sethbern

.pre-commit-config.yaml

@@ -0,0 +1,14 @@
+repos:
+  - repo: https://github.com/psf/black
+    rev: 24.4.2
+    hooks:
+      - id: black
+        types: [python]
+        files: ^(bases|components)/
+
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.4.4
+    hooks:
+      - id: ruff
+        types: [python]
+        files: ^(bases|components)/

CHANGELOG.md

@@ -1,5 +1,33 @@
 # ChangeLog
 
+## Updates since last changelog entry (2026-02-21 → 2026-02-27)
+
+Coverage: commits from **2026-02-21** through **2026-02-27** (i.e., changes after the prior cutoff on 2026-02-20).
+
+### Highlights
+
+- **Learning clues (prototype) + student context improvements:** initial prototype of “learning clues” integration landed, plus follow-on work to add context and automate lookup of book ids (primarily in `assignment_server_api/routers/student.py` and `bookfuncs.js`).
+- **Peer/LLM chat robustness:** improvements to async peer messaging (prompt + behavior), fixes for message ordering, and a key fix so the correct API token field is used and LLM peer lookup can retrieve keys at call time.
+- **LTI1p3 UX:** better messaging when an LMS rejects access to an **expired course**.
+- **UI theming iteration:** dark-mode dropdown styling changes were introduced and then reverted (net effect: continued iteration/experimentation in this area).
+- **Code quality + dependencies:** a broad pass fixing **Black/Ruff** issues and updating lock files / dependencies.
+
+### Commit notes (for reference)
+
+- 1a181c81 Initial prototype of learning clues integration
+- 3f42fae0 log todos
+- 5964439a Add context and automate lookup of book ids
+- c523c054 Fix API token field selection + make LLM peer lookup retrieve keys at call time
+- 8e375a9c Fix message ordering in async peer chat display
+- c34931a8 update prompt and async peer messaging
+- bde25ecd LTI1p3: better message when LMS rejects accessing an expired course
+- eca2ee17 fix dark mode for dropdown menu…
+- cacd4e49 Revert "fix dark mode for dropdown menu…"
+- 968f1cd9 Fix all black errors
+- 0b40954b Fix all black and ruff issues
+
+---
+
 ## Updates since last changelog entry (2026-02-12 → 2026-02-20)
 
 Coverage: commits from **2026-02-12** through **2026-02-20** (i.e., changes after the prior cutoff on 2026-02-11).

bases/rsptx/admin_server_api/routers/instructor.py

@@ -1081,6 +1081,7 @@ async def _copy_one_assignment(
             course=target_course.id,
             name=old_assignment.name,
             duedate=due_date,
+            updated_date=datetime.datetime.now(),
             description=old_assignment.description,
             points=old_assignment.points,
             threshold_pct=old_assignment.threshold_pct,

bases/rsptx/admin_server_api/routers/lti1p3.py

@@ -77,6 +77,7 @@
     fetch_instructor_courses,
     validate_user_credentials,
 )
+from rsptx.db.crud.assignment import is_assignment_visible_to_students
 
 from rsptx.configuration import settings
 from rsptx.logging import rslogger
@@ -445,7 +446,10 @@ async def launch(request: Request):
                 status_code=400, detail=f"Assignment {lineitem_assign_id} not found"
             )
 
-        if not rs_assign.visible and not message_launch.check_teacher_access():
+        if (
+            not is_assignment_visible_to_students(rs_assign)
+            and not message_launch.check_teacher_access()
+        ):
             raise HTTPException(
                 status_code=400,
                 detail=f"Assignment {rs_assign.name} is not open for students",
@@ -874,10 +878,19 @@ async def dynamic_link_entry(request: Request):
     assignments.sort(key=lambda a: a.name)
     assignments.sort(key=lambda a: a.duedate)
 
-    # all lineitems in the LMS
-    ags = message_launch.get_ags()
-    l_items = await ags.get_lineitems()
+    try:
+        # all lineitems in the LMS - may be rejected if course is closed in LMS
+        ags = message_launch.get_ags()
+        l_items = await ags.get_lineitems()
+    except LtiServiceException as e:
+        rslogger.error(f"LTI1p3 - Error accessing course line items: {e}")
+        raise HTTPException(
+            status_code=422,
+            detail="This course appears to be closed in your Learning Management System.",
+        )
+
     l_items.sort(key=lambda li: li.get("label"))
+
     # build lookup dicts for line items
     l_items_resourceId_dict = {li.get("resourceId"): li for li in l_items}
     l_items_label_dict = {li.get("label"): li for li in l_items}

bases/rsptx/assignment_server_api/assignment_builder/package-lock.json

@@ -54,6 +54,7 @@
     "prismjs": "^1.30.0",
     "quill": "^2.0.3",
     "react": "^18.2.0",
+    "react-datepicker": "^7.6.0",
     "react-dom": "^18.2.0",
     "react-hook-form": "^7.53.2",
     "react-hot-toast": "^2.4.1",

bases/rsptx/assignment_server_api/assignment_builder/package.json

@@ -350,7 +350,6 @@
 .formField textarea,
 .formField :global(.p-inputtext),
 .formField :global(.p-inputtextarea),
-.formField :global(.p-calendar),
 .formField :global(.p-inputnumber),
 .formField :global(.p-selectbutton) {
   width: 100%;

bases/rsptx/assignment_server_api/assignment_builder/src/components/routes/AssignmentBuilder/AssignmentBuilder.module.css

@@ -96,7 +96,7 @@ export const AssignmentBuilder = () => {
   // Event handlers
   const handleCreateNew = () => {
     navigateToCreate("basic");
-    reset(defaultAssignment);
+    reset(defaultAssignment as unknown as Assignment);
   };
 
   const handleEdit = (assignment: Assignment) => {
@@ -108,18 +108,6 @@ export const AssignmentBuilder = () => {
     await duplicateAssignment(assignment.id);
   };
 
-  const handleVisibilityChange = async (assignment: Assignment, visible: boolean) => {
-    try {
-      await updateAssignment({
-        ...assignment,
-        visible
-      });
-      toast.success(`Assignment ${visible ? "visible" : "hidden"} for students`);
-    } catch (error) {
-      toast.error("Failed to update assignment visibility");
-    }
-  };
-
   const handleReleasedChange = async (assignment: Assignment, released: boolean) => {
     try {
       await updateAssignment({
@@ -156,6 +144,21 @@ export const AssignmentBuilder = () => {
     }
   };
 
+  const handleVisibilityChange = async (
+    assignment: Assignment,
+    data: { visible: boolean; visible_on: string | null; hidden_on: string | null }
+  ) => {
+    try {
+      await updateAssignment({
+        ...assignment,
+        ...data
+      });
+      toast.success("Visibility updated");
+    } catch (error) {
+      toast.error("Failed to update visibility");
+    }
+  };
+
   const handleWizardComplete = async () => {
     const formValues = getValues();
     const payload: CreateAssignmentPayload = {
@@ -168,7 +171,9 @@ export const AssignmentBuilder = () => {
       nofeedback: formValues.nofeedback,
       nopause: formValues.nopause,
       peer_async_visible: formValues.peer_async_visible,
-      visible: false,
+      visible: formValues.visible,
+      visible_on: formValues.visible_on || null,
+      hidden_on: formValues.hidden_on || null,
       released: true,
       enforce_due: formValues.enforce_due || false
     };
@@ -204,10 +209,10 @@ export const AssignmentBuilder = () => {
           onCreateNew={handleCreateNew}
           onEdit={handleEdit}
           onDuplicate={handleDuplicate}
-          onVisibilityChange={handleVisibilityChange}
           onReleasedChange={handleReleasedChange}
           onEnforceDueChange={handleEnforceDueChange}
           onPeerAsyncChange={handlePeerAsyncChange}
+          onVisibilityChange={handleVisibilityChange}
           onRemove={onRemove}
         />
       )}
@@ -218,13 +223,21 @@ export const AssignmentBuilder = () => {
           nameError={nameError}
           canProceed={canProceed}
           onBack={() => {
-            if (wizardStep === "type") {
+            if (wizardStep === "visibility") {
+              updateWizardStep("type");
+            } else if (wizardStep === "type") {
               updateWizardStep("basic");
             } else {
               navigateToList();
             }
           }}
-          onNext={() => updateWizardStep("type")}
+          onNext={() => {
+            if (wizardStep === "basic") {
+              updateWizardStep("type");
+            } else if (wizardStep === "type") {
+              updateWizardStep("visibility");
+            }
+          }}
           onComplete={handleWizardComplete}
           onNameChange={handleNameChange}
           onTypeSelect={(type) => handleTypeSelect(type, setValue)}