Add pre-commit configuration and update dependencies in pyproject.toml

Author: morozov-av

.pre-commit-config.yaml

@@ -0,0 +1,14 @@
+repos:
+  - repo: https://github.com/psf/black
+    rev: 24.4.2
+    hooks:
+      - id: black
+        types: [python]
+        files: ^(bases|components)/
+
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.4.4
+    hooks:
+      - id: ruff
+        types: [python]
+        files: ^(bases|components)/

bases/rsptx/assignment_server_api/routers/instructor.py

@@ -357,7 +357,7 @@ async def get_assignment_gb(
 
     names = {}
     for ix, row in pt.iterrows():
-        if type(row.first_name) is str and type(row.last_name) is str:
+        if isinstance(row.first_name, str) and isinstance(row.last_name, str):
             names[row.username] = row.first_name + " " + row.last_name
 
     # pt = pt.drop(columns=["username"], axis=1)
@@ -1222,9 +1222,9 @@ async def do_download_assignment(
         csv_buffer,
         media_type="text/csv",
     )
-    response.headers[
-        "Content-Disposition"
-    ] = f"attachment; filename=assignment_{assignment_id}.csv"
+    response.headers["Content-Disposition"] = (
+        f"attachment; filename=assignment_{assignment_id}.csv"
+    )
 
     return response
 

components/rsptx/build_tools/build.py

@@ -431,9 +431,9 @@ def wheel(config):
 
                             res = subprocess.run(lock_opts, capture_output=True)
                             if res.returncode != 0:
-                                status[
-                                    proj
-                                ] = f"[red]Fail[/red] probable dependency conflict see {projdir}/build.log"
+                                status[proj] = (
+                                    f"[red]Fail[/red] probable dependency conflict see {projdir}/build.log"
+                                )
                                 lt.update(generate_wheel_table(status))
                                 if config.verbose:
                                     console.print(

components/rsptx/db/crud/assignment.py

@@ -1,5 +1,4 @@
 from typing import Optional, List
-from datetime import datetime
 from fastapi import HTTPException, status
 from asyncpg.exceptions import UniqueViolationError
 from rsptx.validation import schemas

components/rsptx/lti1p3/pylti1p3/tool_config/abstract.py

@@ -39,14 +39,14 @@ def check_iss_has_many_clients(self, iss: str) -> bool:
         return iss_type == IssuerToClientRelation.MANY_CLIENTS_IDS_PER_ISSUER
 
     def set_iss_has_one_client(self, iss: str):
-        self.issuers_relation_types[
-            iss
-        ] = IssuerToClientRelation.ONE_CLIENT_ID_PER_ISSUER
+        self.issuers_relation_types[iss] = (
+            IssuerToClientRelation.ONE_CLIENT_ID_PER_ISSUER
+        )
 
     def set_iss_has_many_clients(self, iss: str):
-        self.issuers_relation_types[
-            iss
-        ] = IssuerToClientRelation.MANY_CLIENTS_IDS_PER_ISSUER
+        self.issuers_relation_types[iss] = (
+            IssuerToClientRelation.MANY_CLIENTS_IDS_PER_ISSUER
+        )
 
     async def find_registration(self, iss: str, *args, **kwargs) -> Registration:
         """

poetry.lock

@@ -127,6 +127,8 @@ json2xml = "^3.21.0"
 pytest-asyncio = "^0.24.0"
 openai = "^1.59.3"
 javalang = "^0.13.0"
+pre-commit = "^4.5.1"
+ruff = "^0.15.2"