Skip to content

Commit 3269dac

Browse files
authored
Fix Node 10 build issues on Windows and update version numbers (#554)
* Fix Node 10 build issues and update version numbers * Fix Node 10 build issues and update version numbers
1 parent 494b69f commit 3269dac

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

binding.gyp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
"targets": [
8787
{
8888
"target_name": "omr-agentcore",
89+
"win_delay_load_hook": "false",
8990
"type": "none",
9091
"dependencies": [
9192
"<(agentcoredir)/binding.gyp:external",
@@ -104,6 +105,7 @@
104105
},
105106
{
106107
"target_name": "appmetrics",
108+
"win_delay_load_hook": "false",
107109
"sources": [
108110
"<(INTERMEDIATE_DIR)/appmetrics.cpp",
109111
"<(srcdir)/headlessutils.cpp",
@@ -129,41 +131,47 @@
129131
},
130132
{
131133
"target_name": "nodeenvplugin",
134+
"win_delay_load_hook": "false",
132135
"type": "shared_library",
133136
"sources": [
134137
"<(srcdir)/plugins/node/env/nodeenvplugin.cpp",
135138
],
136139
},
137140
{
138141
"target_name": "nodeheapplugin",
142+
"win_delay_load_hook": "false",
139143
"type": "shared_library",
140144
"sources": [
141145
"<(srcdir)/plugins/node/heap/nodeheapplugin.cpp",
142146
],
143147
},
144148
{
145149
"target_name": "nodeprofplugin",
150+
"win_delay_load_hook": "false",
146151
"type": "shared_library",
147152
"sources": [
148153
"<(srcdir)/plugins/node/prof/nodeprofplugin.cpp",
149154
],
150155
},
151156
{
152157
"target_name": "nodeloopplugin",
158+
"win_delay_load_hook": "false",
153159
"type": "shared_library",
154160
"sources": [
155161
"<(srcdir)/plugins/node/loop/nodeloopplugin.cpp",
156162
],
157163
},
158164
{
159165
"target_name": "nodegcplugin",
166+
"win_delay_load_hook": "false",
160167
"type": "shared_library",
161168
"sources": [
162169
"<(srcdir)/plugins/node/gc/nodegcplugin.cpp",
163170
],
164171
},
165172
{
166173
"target_name": "install",
174+
"win_delay_load_hook": "false",
167175
"type": "none",
168176
"dependencies": [
169177
"omr-agentcore",

extract_all_binaries.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ var AGENTCORE_PLATFORMS = [
4343
'win32-x64',
4444
'os390-s390x',
4545
];
46-
var AGENTCORE_VERSION = '3.2.8';
47-
var APPMETRICS_VERSION = '4.0.2';
46+
var AGENTCORE_VERSION = '3.2.9';
47+
var APPMETRICS_VERSION = '4.0.1';
4848

4949
var LOG_FILE = path.join(INSTALL_DIR, 'install.log');
5050
var logFileStream = fs.createWriteStream(LOG_FILE, { flags: 'a' });

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"name": "appmetrics",
3-
"version": "4.0.2",
3+
"version": "4.0.1",
44
"engines": {
5-
"node": ">=4"
5+
"node": ">=6"
66
},
77
"description": "Node Application Metrics",
88
"dependencies": {

0 commit comments

Comments
 (0)