Skip to content

Commit c4cc528

Browse files
authored
Merge pull request #491 from stalleyj/https
Fix https outbound probe for Node 8.9.0+
2 parents 8be6545 + 37c10d6 commit c4cc528

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

probes/https-outbound-probe.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,17 @@ var request = require('../lib/request.js');
2222

2323
var url = require('url');
2424
var util = require('util');
25-
26-
// In https 'get' calls 'request' so we only instrument 'request'
27-
var methods = ['request'];
25+
var semver = require('semver');
26+
27+
var methods;
28+
// In Node.js < v8.9.0 'get' calls 'request' so we only instrument 'request'
29+
if (semver.lt(process.version, '8.9.0')) {
30+
methods = ['request'];
31+
} else {
32+
methods = ['request', 'get'];
33+
}
2834

2935
// Probe to instrument outbound https requests
30-
3136
function HttpsOutboundProbe() {
3237
Probe.call(this, 'https'); // match the name of the module we're instrumenting
3338
}

0 commit comments

Comments
 (0)