Skip to content

Commit bc2a3e6

Browse files
committed
gccrs: Fix ICE when handling bad constructor
We just had a typo returning ok true when it should have been false. Fixes #3876 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-struct.cc (TypeCheckStructExpr::visit): fix typo gcc/testsuite/ChangeLog: * rust/compile/issue-3876.rs: New test. Signed-off-by: Philip Herron <[email protected]>
1 parent 8f23ec6 commit bc2a3e6

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

gcc/rust/typecheck/rust-hir-type-check-struct.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ TypeCheckStructExpr::visit (HIR::StructExprFieldIdentifier &field)
362362
if (!ok)
363363
{
364364
rust_error_at (field.get_locus (), "unknown field");
365-
return true;
365+
return false;
366366
}
367367

368368
auto it = adtFieldIndexToField.find (field_index);
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
enum test {
2+
A(i32),
3+
}
4+
5+
fn fun(x: i32) {
6+
test::A { x }
7+
// { dg-error "unknown field" "" { target *-*-* } .-1 }
8+
}

0 commit comments

Comments
 (0)