Skip to content

Commit bb2f03a

Browse files
SaschaWillemsSaschaWillems
committed
Remove superflous explicit command buffer reset call
Implicitly handled via command pool flag
1 parent b6ce967 commit bb2f03a

File tree

90 files changed

+98
-195
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

90 files changed

+98
-195
lines changed

‎examples/bloom/bloom.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -548,8 +548,7 @@ class VulkanExample : public VulkanExampleBase
548548
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
549549

550550
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
551-
vkResetCommandBuffer(cmdBuffer, 0);
552-
551+
553552
/*
554553
The blur method used in this example is multi pass and renders the vertical blur first and then the horizontal one
555554
While it's possible to blur in one pass, this method is widely used as it requires far less samples to generate the blur

‎examples/bufferdeviceaddress/bufferdeviceaddress.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,7 @@ class VulkanExample : public VulkanExampleBase
234234
void buildCommandBuffer()
235235
{
236236
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
237-
vkResetCommandBuffer(cmdBuffer, 0);
238-
237+
239238
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
240239

241240
VkClearValue clearValues[2]{};

‎examples/computecloth/computecloth.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -582,8 +582,7 @@ class VulkanExample : public VulkanExampleBase
582582
void buildGraphicsCommandBuffer()
583583
{
584584
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
585-
vkResetCommandBuffer(cmdBuffer, 0);
586-
585+
587586
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
588587

589588
VkClearValue clearValues[2]{};
@@ -642,8 +641,7 @@ class VulkanExample : public VulkanExampleBase
642641
void buildComputeCommandBuffer()
643642
{
644643
VkCommandBuffer cmdBuffer = compute.commandBuffers[currentBuffer];
645-
vkResetCommandBuffer(cmdBuffer, 0);
646-
644+
647645
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
648646

649647
VK_CHECK_RESULT(vkBeginCommandBuffer(cmdBuffer, &cmdBufInfo));

‎examples/computecullandlod/computecullandlod.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -523,8 +523,7 @@ class VulkanExample : public VulkanExampleBase
523523
void buildGraphicsCommandBuffer()
524524
{
525525
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
526-
vkResetCommandBuffer(cmdBuffer, 0);
527-
526+
528527
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
529528

530529
VkClearValue clearValues[2]{};
@@ -635,8 +634,7 @@ class VulkanExample : public VulkanExampleBase
635634
void buildComputeCommandBuffer()
636635
{
637636
VkCommandBuffer cmdBuffer = compute.commandBuffers[currentBuffer];
638-
vkResetCommandBuffer(cmdBuffer, 0);
639-
637+
640638
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
641639

642640
VK_CHECK_RESULT(vkBeginCommandBuffer(cmdBuffer, &cmdBufInfo));

‎examples/computenbody/computenbody.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -461,8 +461,7 @@ class VulkanExample : public VulkanExampleBase
461461
void buildGraphicsCommandBuffer()
462462
{
463463
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
464-
vkResetCommandBuffer(cmdBuffer, 0);
465-
464+
466465
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
467466

468467
VkClearValue clearValues[2]{};
@@ -559,8 +558,7 @@ class VulkanExample : public VulkanExampleBase
559558
void buildComputeCommandBuffer()
560559
{
561560
VkCommandBuffer cmdBuffer = compute.commandBuffers[currentBuffer];
562-
vkResetCommandBuffer(cmdBuffer, 0);
563-
561+
564562
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
565563

566564
VK_CHECK_RESULT(vkBeginCommandBuffer(cmdBuffer, &cmdBufInfo));

‎examples/computeparticles/computeparticles.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -389,8 +389,7 @@ class VulkanExample : public VulkanExampleBase
389389
void buildGraphicsCommandBuffer()
390390
{
391391
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
392-
vkResetCommandBuffer(cmdBuffer, 0);
393-
392+
394393
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
395394

396395
VkClearValue clearValues[2]{};
@@ -487,8 +486,7 @@ class VulkanExample : public VulkanExampleBase
487486
void buildComputeCommandBuffer()
488487
{
489488
VkCommandBuffer cmdBuffer = compute.commandBuffers[currentBuffer];
490-
vkResetCommandBuffer(cmdBuffer, 0);
491-
489+
492490
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
493491

494492
VK_CHECK_RESULT(vkBeginCommandBuffer(cmdBuffer, &cmdBufInfo));

‎examples/computeraytracing/computeraytracing.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -446,8 +446,7 @@ class VulkanExample : public VulkanExampleBase
446446
void buildGraphicsCommandBuffer()
447447
{
448448
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
449-
vkResetCommandBuffer(cmdBuffer, 0);
450-
449+
451450
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
452451

453452
VkClearValue clearValues[2]{};
@@ -547,8 +546,7 @@ class VulkanExample : public VulkanExampleBase
547546
void buildComputeCommandBuffer()
548547
{
549548
VkCommandBuffer cmdBuffer = compute.commandBuffers[currentBuffer];
550-
vkResetCommandBuffer(cmdBuffer, 0);
551-
549+
552550
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
553551

554552
VK_CHECK_RESULT(vkBeginCommandBuffer(cmdBuffer, &cmdBufInfo));

‎examples/computeshader/computeshader.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,6 @@ class VulkanExample : public VulkanExampleBase
428428
void buildComputeCommandBuffer()
429429
{
430430
VkCommandBuffer cmdBuffer = compute.commandBuffers[currentBuffer];
431-
vkResetCommandBuffer(cmdBuffer, 0);
432431
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
433432
VK_CHECK_RESULT(vkBeginCommandBuffer(cmdBuffer, &cmdBufInfo));
434433
vkCmdBindPipeline(cmdBuffer, VK_PIPELINE_BIND_POINT_COMPUTE, compute.pipelines[compute.pipelineIndex]);
@@ -440,8 +439,7 @@ class VulkanExample : public VulkanExampleBase
440439
void buildGraphicsCommandBuffer()
441440
{
442441
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
443-
vkResetCommandBuffer(cmdBuffer, 0);
444-
442+
445443
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
446444

447445
VkClearValue clearValues[2]{};

‎examples/conditionalrender/conditionalrender.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,8 +268,7 @@ class VulkanExample : public VulkanExampleBase
268268
void buildCommandBuffer()
269269
{
270270
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
271-
vkResetCommandBuffer(cmdBuffer, 0);
272-
271+
273272
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
274273

275274
VkClearValue clearValues[2]{};

‎examples/conservativeraster/conservativeraster.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -556,8 +556,7 @@ class VulkanExample : public VulkanExampleBase
556556
void buildCommandBuffer()
557557
{
558558
VkCommandBuffer cmdBuffer = drawCmdBuffers[currentBuffer];
559-
vkResetCommandBuffer(cmdBuffer, 0);
560-
559+
561560
VkCommandBufferBeginInfo cmdBufInfo = vks::initializers::commandBufferBeginInfo();
562561

563562
VK_CHECK_RESULT(vkBeginCommandBuffer(cmdBuffer, &cmdBufInfo));

0 commit comments

Comments
 (0)