Make Windows CI more similar to Linux CI.

Because inconsistencies without a clear reason are confusing.

Specifically:
- Use `v4` of `actions/checkout`.
- Add rustfmt and clippy checks (and fix a couple of clippy warnings).
- Exclude fewer things from the build and docs steps.

Author: nnethercote

.github/workflows/ci_linux.yml

@@ -72,6 +72,7 @@ jobs:
         run: |
           nvcc --version
           rustup show
+
       - name: Load Rust cache
         uses: Swatinem/rust-cache@v2
         with:
@@ -91,6 +92,10 @@ jobs:
           RUSTFLAGS: -Dwarnings
         run: cargo clippy --workspace --exclude "optix*" --exclude "path-tracer" --exclude "denoiser" --exclude "ex*" --exclude "cudnn*"
 
+      # Don't currently test because many tests rely on the system having a CUDA GPU
+      # - name: Test
+      #   run: cargo test --workspace
+
       - name: Check documentation
         env:
           RUSTDOCFLAGS: -Dwarnings

.github/workflows/ci_windows.yml

@@ -43,7 +43,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Install CUDA
         uses: Jimver/[email protected]
@@ -56,9 +56,6 @@ jobs:
           sub-packages: ${{ toJson(matrix.sub-packages) }}
           log-file-suffix: "${{matrix.os}}-${{matrix.cuda}}"
 
-      - name: Verify CUDA installation
-        run: nvcc --version
-
       - name: List CUDA_PATH files
         shell: pwsh
         run: Get-ChildItem -Path $env:CUDA_PATH -Recurse | ForEach-Object { $_.FullName }
@@ -70,17 +67,30 @@ jobs:
       - name: Add rustup components
         run: rustup component add rustfmt clippy
 
+      - name: Verify CUDA, Rust installation
+        run: |
+          nvcc --version
+          rustup show
+
       - name: Load Rust Cache
         uses: Swatinem/[email protected]
         with:
           key: ${{ matrix.os }}-${{ matrix.target }}-${{ matrix.cuda }}
 
+      - name: Rustfmt
+        run: cargo fmt --all -- --check
+
       - name: Build all bindings
         run: cargo build --all-features -p cust_raw
 
-      - name: Build
+      - name: Build workspace
         run: cargo build --workspace --exclude "optix*" --exclude "path-tracer" --exclude "denoiser" --exclude "vecadd*" --exclude "gemm*" --exclude "ex*" --exclude "cudnn*" --exclude "sha2*"
 
+      - name: Clippy
+        env:
+          RUSTFLAGS: -Dwarnings
+        run: cargo clippy --workspace --exclude "optix*" --exclude "path-tracer" --exclude "denoiser" --exclude "vecadd*" --exclude "gemm*" --exclude "ex*" --exclude "cudnn*" --exclude "sha2*"
+
       # Don't currently test because many tests rely on the system having a CUDA GPU
       # - name: Test
       #   run: cargo test --workspace
@@ -89,6 +99,7 @@ jobs:
         env:
           RUSTDOCFLAGS: -Dwarnings
         run: cargo doc --workspace --all-features --document-private-items --no-deps --exclude "optix*" --exclude "path-tracer" --exclude "denoiser" --exclude "vecadd*" --exclude "gemm*" --exclude "ex*" --exclude "cudnn*" --exclude "sha2*" --exclude "cust_raw"
+
       # Disabled due to dll issues, someone with  Windows knowledge needed
       # - name: Compiletest
       #  run: cargo run -p compiletests --release --no-default-features -- --target-arch compute_61,compute_70,compute_90

tests/compiletests/src/main.rs

@@ -531,7 +531,7 @@ fn find_rustc_codegen_nvvm(workspace_root: &Path) -> PathBuf {
             // On Windows, ensure the directory containing the DLL is in PATH
             // so that its dependencies can be found
             #[cfg(windows)]
-            setup_windows_dll_path(&path);
+            setup_windows_dll_path(path);
 
             return path.clone();
         }
@@ -554,7 +554,7 @@ fn find_rustc_codegen_nvvm(workspace_root: &Path) -> PathBuf {
         if path.is_file() {
             // On Windows, ensure the directory containing the DLL is in PATH
             #[cfg(windows)]
-            setup_windows_dll_path(&path);
+            setup_windows_dll_path(path);
 
             return path.clone();
         }