Skip to content

Conversation

nnethercote
Copy link
Collaborator

@nnethercote nnethercote commented Oct 1, 2025

Details in individual commits.

It's a bit weird to run clippy first, because vanilla compile errors
show up in the clippy results.
@nnethercote nnethercote force-pushed the ci-consistency branch 2 times, most recently from e85f9e3 to d0669d8 Compare October 1, 2025 05:46
Because inconsistencies without a clear reason are confusing.

Specifically:
- Use `v4` of `actions/checkout`.
- Add rustfmt and clippy checks (and fix a couple of clippy warnings).
- Exclude fewer things from the build and docs steps.
These confused me because I thought they were matching `examples/`, when
really they are matching `ex02_pipeline`, `ex03_window`, `ex04_mesh`,
and `ex04_mesh_gpu`.
@nnethercote nnethercote changed the title Make Windows CI more similar to Linux CI. A few CI improvements Oct 1, 2025
@nnethercote nnethercote requested a review from LegNeato October 1, 2025 06:41
@nnethercote nnethercote marked this pull request as ready for review October 1, 2025 06:41
@nnethercote nnethercote marked this pull request as draft October 1, 2025 06:42
@nnethercote nnethercote marked this pull request as ready for review October 1, 2025 10:10
Copy link
Contributor

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! These quality of life fixes make a huge difference, thank you for fixing as you came across instead of ignoring ❤️

@LegNeato LegNeato merged commit 1b253fd into Rust-GPU:main Oct 6, 2025
30 of 31 checks passed
@nnethercote nnethercote deleted the ci-consistency branch October 7, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants