Use From impls instead of factory functions

Author: LegNeato

tests/difftests/bin/src/differ.rs

@@ -246,24 +246,26 @@ impl DifferenceDisplay for F32Differ {
     }
 }
 
-/// Factory function to create appropriate differ based on output type
-pub fn create_differ(output_type: OutputType) -> Box<dyn OutputDiffer + Send + Sync> {
-    match output_type {
-        OutputType::Raw => Box::new(RawDiffer),
-        OutputType::F32 => Box::new(F32Differ),
-        OutputType::F64 => todo!("F64Differ not implemented yet"),
-        OutputType::U32 => todo!("U32Differ not implemented yet"),
-        OutputType::I32 => todo!("I32Differ not implemented yet"),
+impl From<OutputType> for Box<dyn OutputDiffer + Send + Sync> {
+    fn from(output_type: OutputType) -> Self {
+        match output_type {
+            OutputType::Raw => Box::new(RawDiffer),
+            OutputType::F32 => Box::new(F32Differ),
+            OutputType::F64 => todo!("F64Differ not implemented yet"),
+            OutputType::U32 => todo!("U32Differ not implemented yet"),
+            OutputType::I32 => todo!("I32Differ not implemented yet"),
+        }
     }
 }
 
-/// Factory function to create appropriate display based on output type
-pub fn create_display(output_type: OutputType) -> Box<dyn DifferenceDisplay + Send + Sync> {
-    match output_type {
-        OutputType::Raw => Box::new(RawDiffer),
-        OutputType::F32 => Box::new(F32Differ),
-        OutputType::F64 => todo!("F64Display not implemented yet"),
-        OutputType::U32 => todo!("U32Display not implemented yet"),
-        OutputType::I32 => todo!("I32Display not implemented yet"),
+impl From<OutputType> for Box<dyn DifferenceDisplay + Send + Sync> {
+    fn from(output_type: OutputType) -> Self {
+        match output_type {
+            OutputType::Raw => Box::new(RawDiffer),
+            OutputType::F32 => Box::new(F32Differ),
+            OutputType::F64 => todo!("F64Display not implemented yet"),
+            OutputType::U32 => todo!("U32Display not implemented yet"),
+            OutputType::I32 => todo!("I32Display not implemented yet"),
+        }
     }
 }

tests/difftests/bin/src/runner.rs

@@ -12,7 +12,7 @@ use tempfile::NamedTempFile;
 use thiserror::Error;
 use tracing::{debug, error, info, trace};
 
-use crate::differ::{Difference, DifferenceDisplay, OutputDiffer, create_differ, create_display};
+use crate::differ::{Difference, DifferenceDisplay, OutputDiffer};
 
 #[derive(Debug, Error)]
 pub enum RunnerError {
@@ -386,8 +386,8 @@ impl Runner {
         let output_type = output_type.unwrap_or(OutputType::Raw);
         let groups = self.group_outputs(&pkg_outputs, epsilon, output_type);
         if groups.len() > 1 {
-            let differ = create_differ(output_type);
-            let display = create_display(output_type);
+            let differ: Box<dyn OutputDiffer + Send + Sync> = output_type.into();
+            let display: Box<dyn DifferenceDisplay + Send + Sync> = output_type.into();
 
             // Write human-readable outputs
             for po in &pkg_outputs {