Skip to content

Conversation

@LegNeato
Copy link
Collaborator

No description provided.

@schell
Copy link
Contributor

schell commented Mar 16, 2025

@LegNeato could you add a little description just to give me some context? Where does ARTIFACT_SUFFIX come from?

@LegNeato
Copy link
Collaborator Author

LegNeato commented Mar 17, 2025

Sure! ARTIFACT_SUFFIX is defined in that file as the same static string. The suffix is for json metadata that is written out next to the artifact...sort of an API between the compiler backend and spirvbuilder. It appears to only be written with certain crate types. I was debugging another issue and saw that in the same file it uses the hardcoded string and the constant in different places, likely just an oversight:

https://github.com/Rust-GPU/rust-gpu/pull/218/files#diff-84c98121dbc8466f5e6e1503a3771f2ec4f8f37fa048ebf01c201b1b5cd1b191R903

@LegNeato LegNeato enabled auto-merge March 17, 2025 01:07
@LegNeato LegNeato added this pull request to the merge queue Mar 17, 2025
Merged via the queue into Rust-GPU:main with commit 4f072f7 Mar 17, 2025
7 checks passed
@LegNeato LegNeato deleted the LegNeato-patch-1 branch March 17, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants