-
Notifications
You must be signed in to change notification settings - Fork 82
spirv_builder feature compile_codegen to disable building rustc_codegen_spirv
#245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 22 commits
30c6502
a30c580
dd056a3
7e3a7b5
49a962b
1c0baee
fe42c46
674214b
879338b
bb5d2e0
5235161
de2cef8
d643a65
6a518ac
744c844
9a9ebc1
da624d1
b619665
dcbdc52
e040ab9
b8f659b
eca83df
5db761e
3c9a7d7
74d1c66
d8f0398
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,4 @@ target/ | |
| tests/Cargo.lock | ||
| .github/install-spirv-tools/Cargo.lock | ||
| rustc-ice-*.txt | ||
| .idea | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,13 +18,17 @@ no-default-features = true | |
| # that optional dependency, from being automatically created by Cargo, see: | ||
| # https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies | ||
| [features] | ||
| # See `rustc_codegen_spirv/Cargo.toml` for details on these features. | ||
| default = ["use-compiled-tools"] | ||
| use-installed-tools = ["dep:rustc_codegen_spirv", "rustc_codegen_spirv?/use-installed-tools"] | ||
| use-compiled-tools = ["dep:rustc_codegen_spirv", "rustc_codegen_spirv?/use-compiled-tools"] | ||
| # Compile `rustc_codegen_spirv`, allows constructing SpirvBuilder without | ||
| # explicitly passing in a path to a compiled `rustc_codegen_spirv.so` (or dll) | ||
| rustc_codegen_spirv = ["dep:rustc_codegen_spirv"] | ||
| # See `rustc_codegen_spirv/Cargo.toml` for details on these features. | ||
| use-installed-tools = ["rustc_codegen_spirv", "rustc_codegen_spirv?/use-installed-tools"] | ||
| use-compiled-tools = ["rustc_codegen_spirv", "rustc_codegen_spirv?/use-compiled-tools"] | ||
| skip-toolchain-check = ["rustc_codegen_spirv?/skip-toolchain-check"] | ||
|
|
||
| watch = ["dep:notify"] | ||
| clap = ["dep:clap"] | ||
|
|
||
| [dependencies] | ||
| # See comment in `src/lib.rs` `invoke_rustc` regarding `rustc_codegen_spirv` dep. | ||
|
|
@@ -38,5 +42,9 @@ memchr = "2.4" | |
| raw-string = "0.3.5" | ||
| serde = { version = "1.0", features = ["derive"] } | ||
| serde_json = "1.0" | ||
| thiserror = "2.0.12" | ||
| semver = { version = "1.0.24", features = ["serde"] } | ||
|
|
||
| notify = { version = "7.0", optional = true } | ||
| # Pinning clap, as newer versions have raised min rustc version without being marked a breaking change | ||
| clap = { version = "=4.5.37", optional = true, features = ["derive"] } | ||
|
Comment on lines
+49
to
+50
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is really annoying, can this constraint be lifted now that the toolchain was upgraded? This prevents me from using newer clap version in the workspace downstream. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I seem to remember that I pinned that. Running
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that you no longer directly depend on old spirv-builder versions since I refactored cargo-gpu, we always use the newest one. Only the codegen backend is now compiled in a potentially quite old toolchain, which doesn't need clap.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Already updated in #349, everything looks good so far |
||
Uh oh!
There was an error while loading. Please reload this page.